Skip to content

docs(repo): the patch arm's name rule, the tasks check flag and host record, both new arms in the README - #199

Open
antonwolfy wants to merge 1 commit into
intel:mainfrom
antonwolfy:docs/repo-contract-leftovers
Open

antonwolfy wants to merge 1 commit into
intel:mainfrom
antonwolfy:docs/repo-contract-leftovers

Conversation

@antonwolfy

Copy link
Copy Markdown
Contributor

Summary

Doc points from the reviews of #117 and #112 that were still open when they merged. xaleryb and napetrov had also left the README row "still open for the author" on #117. Only docs change.

Changes

  • The patch: arm's name (thread on #117). The contract said every character outside [A-Za-z0-9.-] becomes _. parse_arm does more:

    • each run of such characters becomes one _;
    • a leading or trailing _ is dropped;
    • the result is cut to 40 characters, and a _ the cut leaves at the end is dropped too.

    So my fix (v2).diff is my_fix_v2_.diff. The paragraph's 130-character line is re-wrapped.

  • README (#117 review): the arm table lists guidance:rev:<rev> and patch:<file> next to guidance:none|raw|bridge.

  • repo tasks check (#112 review):

    • the S5 usage line has [--allow-unsupported];
    • the self-check example's "exits 1 if any task is broken or unsupported" gets the exception;
    • §4.3 names where the host probe's facts go: check.json host, and the batch's _eval/host.json for repo run.

Risk

None to behaviour. #176 rewrites the same example comment line in repo-evaluation-contract.md, so whichever merges second resolves one line.

Testing

On a Linux review host, at 2140faf (on main 506f7ba):

  • make ci-local: 29 passed, 0 failed, 7 skipped (the Docker catalog smoke, test-latest, the cli-surface packaging step, conda-forge-deps without micromamba, docs deploy, the pip-audit report, semgrep). 7,381 tests passed, 1 skipped.
  • Rebased onto main 92d92d3 (test(llm): pin provider-call budgets for judge, panel, answer and validation paths #170, tests only) before opening; with the ten follow-up branches merged together, the full suite (7,447 passed, 1 skipped), the growth check, mypy and ruff pass.

Checklist

  • Tests added/updated and pytest passes
  • ruff, mypy, and schema checks pass
  • Docs updated (or N/A) — see the docs-drift checklist in CONTRIBUTING.md
  • No ad-hoc run artifacts committed
  • New files carry the SPDX license header (or are exempt in .github/.licenserc.yaml)

…record, both new arms in the README

Leftovers from the reviews of intel#117 and intel#112:
- The contract said every character outside [A-Za-z0-9.-] becomes `_`.
  The code turns each run into one `_`, drops a leading or trailing `_`
  and cuts at 40, so `my fix (v2).diff` is `my_fix_v2_.diff`. Also re-wrap
  the paragraph's 130-character line.
- The S5 usage of `repo tasks check` lacked `--allow-unsupported`, and the
  example's "exits 1 if any task is unsupported" had no exception for it.
- §4.3 names where the host probe's facts go: `check.json` `host` and the
  batch's `_eval/host.json`.
- The README's arm table lists `guidance:rev:<rev>` and `patch:<file>`.

Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
@vchamarthi

Copy link
Copy Markdown
Contributor

@exai-bot /review

@exai-bot exai-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

AI-generated review of dd218a993352, requested by @vchamarthi, using the default review skill. It can be wrong: verify a finding before acting on it. React with a thumbs up or down on a finding to tell the bot whether it helped.
Model us.anthropic.claude-sonnet-5-5, effort default, 3 of 80 turns, 0.2 of 40 minutes, 39k in / 925 out tokens.

Docs-only change. It corrects the patch: arm's name rule, adds [--allow-unsupported] to the repo tasks check usage and example, records where the host probe's facts go, and lists the two new arms in the README table. I checked each claim against the code and found no discrepancies.

No issues found.

Not verified

I traced the my fix (v2).diff → my_fix_v2_.diff example by hand through the regex in parse_arm. I did not run it.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.77%. Comparing base (92d92d3) to head (dd218a9).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.02%     
==========================================
  Files         223      223              
  Lines       27623    27623              
  Branches     4549     4549              
==========================================
- Hits        25354    25350       -4     
- Misses       1606     1609       +3     
- Partials      663      664       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@napetrov napetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs corrections look right. As noted in Risk, #176 touches the same example line in repo-evaluation-contract.md; let's agree which lands first so the second rebases once.

@napetrov napetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff: the patch-arm name rule now matches parse_arm, the README lists both new arms, and the --allow-unsupported/host-record notes are right. LGTM; just sequence with #176.

@antonwolfy

Copy link
Copy Markdown
Contributor Author

@napetrov agreed. #176 is the larger change, so let it land first. I'll rebase #199 right after; the conflict is the one example comment line.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants