Repository navigation
docs(repo): the patch arm's name rule, the tasks check flag and host record, both new arms in the README - #199
antonwolfy wants to merge 1 commit into
Conversation
…record, both new arms in the README Leftovers from the reviews of intel#117 and intel#112: - The contract said every character outside [A-Za-z0-9.-] becomes `_`. The code turns each run into one `_`, drops a leading or trailing `_` and cuts at 40, so `my fix (v2).diff` is `my_fix_v2_.diff`. Also re-wrap the paragraph's 130-character line. - The S5 usage of `repo tasks check` lacked `--allow-unsupported`, and the example's "exits 1 if any task is unsupported" had no exception for it. - §4.3 names where the host probe's facts go: `check.json` `host` and the batch's `_eval/host.json`. - The README's arm table lists `guidance:rev:<rev>` and `patch:<file>`. Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
|
@exai-bot /review |
exai-bot
left a comment
There was a problem hiding this comment.
Note
AI-generated review of dd218a993352, requested by @vchamarthi, using the default review skill. It can be wrong: verify a finding before acting on it. React with a thumbs up or down on a finding to tell the bot whether it helped.
Model us.anthropic.claude-sonnet-5-5, effort default, 3 of 80 turns, 0.2 of 40 minutes, 39k in / 925 out tokens.
Docs-only change. It corrects the patch: arm's name rule, adds [--allow-unsupported] to the repo tasks check usage and example, records where the host probe's facts go, and lists the two new arms in the README table. I checked each claim against the code and found no discrepancies.
No issues found.
Not verified
I traced the my fix (v2).diff → my_fix_v2_.diff example by hand through the regex in parse_arm. I did not run it.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.02%
==========================================
Files 223 223
Lines 27623 27623
Branches 4549 4549
==========================================
- Hits 25354 25350 -4
- Misses 1606 1609 +3
- Partials 663 664 +1 🚀 New features to boost your workflow:
|
Summary
Doc points from the reviews of #117 and #112 that were still open when they merged. xaleryb and napetrov had also left the README row "still open for the author" on #117. Only docs change.
Changes
The
patch:arm's name (thread on #117). The contract said every character outside[A-Za-z0-9.-]becomes_.parse_armdoes more:_;_is dropped;_the cut leaves at the end is dropped too.So
my fix (v2).diffismy_fix_v2_.diff. The paragraph's 130-character line is re-wrapped.README (#117 review): the arm table lists
guidance:rev:<rev>andpatch:<file>next toguidance:none|raw|bridge.repo tasks check(#112 review):[--allow-unsupported];check.jsonhost, and the batch's_eval/host.jsonforrepo run.Risk
None to behaviour. #176 rewrites the same example comment line in
repo-evaluation-contract.md, so whichever merges second resolves one line.Testing
On a Linux review host, at
2140faf(onmain506f7ba):make ci-local: 29 passed, 0 failed, 7 skipped (the Docker catalog smoke,test-latest, thecli-surfacepackaging step, conda-forge-deps without micromamba, docsdeploy, the pip-audit report, semgrep). 7,381 tests passed, 1 skipped.main92d92d3 (test(llm): pin provider-call budgets for judge, panel, answer and validation paths #170, tests only) before opening; with the ten follow-up branches merged together, the full suite (7,447 passed, 1 skipped), the growth check,mypyandruffpass.Checklist
pytestpassesruff,mypy, and schema checks pass.github/.licenserc.yaml)