Skip to content

refactor(compare): split per-arm checks out of _provenance_warnings - #195

Open
napetrov wants to merge 1 commit into
intel:mainfrom
napetrov:fix/provenance-warnings-complexity
Open

napetrov wants to merge 1 commit into
intel:mainfrom
napetrov:fix/provenance-warnings-complexity

Conversation

@napetrov

Copy link
Copy Markdown
Contributor

#153 took _provenance_warnings to complexity 11, over the cap of 10, so test_growth_ratchet fails on main and on every PR's merge commit (seen first on #186).

This moves the resolved-model and uptake checks into _arm_warnings. The warnings and their order don't change.

Ran the full suite locally: 7245 passed. ruff and mypy are clean on compare.py.

🤖 Generated with Claude Code

intel#153 took _provenance_warnings to complexity 11, over the cap of 10,
so test_growth_ratchet fails on main. Move the resolved-model and
uptake checks into _arm_warnings; the warnings and their order are
unchanged.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.67%. Comparing base (8782e1c) to head (ce3daad).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         223      223           
  Lines       27505    27509    +4     
  Branches     4525     4525           
=======================================
+ Hits        25216    25220    +4     
  Misses       1620     1620           
  Partials      669      669           
Files with missing lines Coverage Δ
dokimi/dokimi/repos/compare.py 99.64% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@napetrov napetrov added the skip-changelog No user-visible change: bypasses the changelog fragment check label Oct 23, 2026
antonwolfy
antonwolfy previously approved these changes Oct 23, 2026

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The split is a verbatim move, and it brings _provenance_warnings from complexity 11 to 8, with _arm_warnings at 4, so the ratchet passes again. No findings.

What I ran, on a Linux review host at ce3daad:

  • make ci-local: 27 passed, 2 failed, 7 skipped; 7246 tests passed. The changelog FAIL is covered by the skip-changelog label. The pip-audit FAIL reports a gitpython 3.2.0 advisory (fix in 3.2.1); this PR touches no dependency files.
  • scripts/check_growth.py and tests/test_growth_ratchet.py: both pass (46 tests). compare.py is 503 lines, under the cap.
  • A mutation run on _arm_warnings: 9 mutants against the compare, uptake, host and run tests, 8 killed (dropped uptake check, dropped models filter, inverted used, swapped arms, models=None at the call site, and others).

Checked, no issues

  • Order: the call sits at the old spot in the per-treatment loop, after the stamp and harness-version warnings, so the output order is unchanged. The trailing mismatch_warnings still comes last.
  • Inputs: cells, baseline, text and models are everything the moved block used; both warning strings are identical.
  • References: nothing else in the repo names _provenance_warnings or _arm_warnings, so no docs need updating.

@antonwolfy

Copy link
Copy Markdown
Contributor

@napetrov merged into the current main (565f653), this PR fails these tests:

  • tests/test_growth_ratchet.py::test_no_file_or_function_grew_past_its_baseline
  • tests/test_growth_ratchet.py::test_no_file_or_function_grew_past_its_baseline

The PR's checks ran before main moved to 565f653, so they did not see it. Merging main into the branch reproduces it; once that is fixed I can merge.

@antonwolfy
antonwolfy dismissed their stale review October 23, 2026 12:31

Dismissing until the growth-baseline entry for _provenance_warnings is dropped (see the comment above: merged into the current main, test_growth_ratchet fails). I'll review again after that.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-visible change: bypasses the changelog fragment check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants