Repository navigation
Conversation
intel#153 took _provenance_warnings to complexity 11, over the cap of 10, so test_growth_ratchet fails on main. Move the resolved-model and uptake checks into _arm_warnings; the warnings and their order are unchanged. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 223 223
Lines 27505 27509 +4
Branches 4525 4525
=======================================
+ Hits 25216 25220 +4
Misses 1620 1620
Partials 669 669
🚀 New features to boost your workflow:
|
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM. The split is a verbatim move, and it brings _provenance_warnings from complexity 11 to 8, with _arm_warnings at 4, so the ratchet passes again. No findings.
What I ran, on a Linux review host at ce3daad:
make ci-local: 27 passed, 2 failed, 7 skipped; 7246 tests passed. ThechangelogFAIL is covered by theskip-changeloglabel. Thepip-auditFAIL reports a gitpython 3.2.0 advisory (fix in 3.2.1); this PR touches no dependency files.scripts/check_growth.pyandtests/test_growth_ratchet.py: both pass (46 tests).compare.pyis 503 lines, under the cap.- A mutation run on
_arm_warnings: 9 mutants against the compare, uptake, host and run tests, 8 killed (dropped uptake check, droppedmodelsfilter, invertedused, swapped arms,models=Noneat the call site, and others).
Checked, no issues
- Order: the call sits at the old spot in the per-treatment loop, after the stamp and harness-version warnings, so the output order is unchanged. The trailing
mismatch_warningsstill comes last. - Inputs:
cells,baseline,textandmodelsare everything the moved block used; both warning strings are identical. - References: nothing else in the repo names
_provenance_warningsor_arm_warnings, so no docs need updating.
|
@napetrov merged into the current
The PR's checks ran before |
Dismissing until the growth-baseline entry for _provenance_warnings is dropped (see the comment above: merged into the current main, test_growth_ratchet fails). I'll review again after that.
#153 took
_provenance_warningsto complexity 11, over the cap of 10, sotest_growth_ratchetfails on main and on every PR's merge commit (seen first on #186).This moves the resolved-model and uptake checks into
_arm_warnings. The warnings and their order don't change.Ran the full suite locally: 7245 passed. ruff and mypy are clean on
compare.py.🤖 Generated with Claude Code