Skip to content

ci(growth): take #153's growth into the baseline; name the PR behind each post-#93 entry - #183

Open
antonwolfy wants to merge 1 commit into
intel:mainfrom
antonwolfy:fix/growth-baseline-after-93
Open

antonwolfy wants to merge 1 commit into
intel:mainfrom
antonwolfy:fix/growth-baseline-after-93

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

main fails tests/test_growth_ratchet.py again: #153 took dokimi/repos/compare.py::_provenance_warnings to complexity 11, over the 10 cap, after #184 reseeded the baseline. Every open PR's Tests job goes red with it, since pull_request CI tests each PR merged into main.

This PR was opened before #184 and did the same reseed. Rebased onto main, it now does two things, both in scripts/growth_baseline.json only:

Entry Change
dokimi/repos/compare.py::_provenance_warnings new, complexity 11, grown by #153
dokimi/llm.py (lines) rationale names #180
dokimi/eval/judge.py::Judge._judge_answer rationale names #180
dokimi/eval/panel.py::JudgePanel._call_judge rationale names #180
dokimi/commands/repo_run.py::_context rationale names #120
dokimi/repos/manifest.py::_check_task rationale names #113 and #120

#184 gave those five the generic "grew on main after the #93 seed" rationale; naming the PR tells whoever splits them where to look. No numbers change except the new entry.

Checked locally on main + this commit: python scripts/check_growth.py exits 0, pytest tests/test_growth_ratchet.py passes (45 passed, 1 skipped). No changelog fragment needed, since only scripts/ changes.

🤖 Generated with Claude Code

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.67%. Comparing base (8782e1c) to head (95e1c37).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         223      223           
  Lines       27505    27505           
  Branches     4525     4525           
=======================================
  Hits        25216    25216           
  Misses       1620     1620           
  Partials      669      669           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchamarthi

Copy link
Copy Markdown
Contributor

@exai-bot /review

@exai-bot exai-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

AI-generated review of 18041013941f, requested by @vchamarthi, using the default review skill. It can be wrong: verify a finding before acting on it. React with a thumbs up or down on a finding to tell the bot whether it helped.
Model us.anthropic.claude-sonnet-5-5, effort default, 4 of 80 turns, 0.2 of 40 minutes, 73k in / 1k out tokens.

This PR reseeds scripts/growth_baseline.json for the growth that landed on main after #93. It raises four entries, adds repo_run.py::_context, and drops the novelty/bundle.py entry. I found no defects. Every raised or added entry has a hand-written rationale, well under the 300-character limit. The rationales differ from the old text, so raised_without_rationale should accept them. The new entry sits in sorted position, matching dump_baseline's ordering. The Tests jobs on py3.11–3.14, which include test_growth_ratchet, are green on the head. The change is limited to the baseline file.

No issues found.

Not verified

I did not recompute the line counts and complexities against the code. I relied on the green Tests jobs, which run test_growth_ratchet, and on the PR's statement that check_growth.py exits 0. I did not check the rationale claims about #120 and #180, such as which PR grew which function.

@napetrov
napetrov force-pushed the fix/growth-baseline-after-93 branch from 1804101 to 5dde85b Compare October 22, 2026 22:43
@napetrov napetrov changed the title ci(growth): reseed the ratchet baseline for main's growth since #93 ci(growth): take #153's growth into the baseline; name the PR behind each post-#93 entry Oct 22, 2026
@napetrov
napetrov force-pushed the fix/growth-baseline-after-93 branch from 5dde85b to 95e1c37 Compare October 22, 2026 23:43
…e in intel#153

intel#184 already took main's growth since the intel#93 seed into the baseline with
a generic rationale. Name the PR behind each of those entries instead, and
add dokimi/repos/compare.py::_provenance_warnings, which intel#153 took over the
complexity cap after intel#184 and which turns main's Tests job red again.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants