Repository navigation
docs(treatments): how to measure tool choice - #158
Conversation
Score the calls rather than the judge, count failed calls on their own, compare against an equal alternative with the order swapped, repeat at temperature=1 instead of pinning, and read a one-call proxy as an upper bound (about 2x the harness effect in the one case measured). Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 91.40% 91.55% +0.14%
==========================================
Files 216 222 +6
Lines 26741 27404 +663
Branches 4377 4508 +131
==========================================
+ Hits 24442 25089 +647
- Misses 1635 1644 +9
- Partials 664 671 +7 🚀 New features to boost your workflow:
|
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM. The new section is accurate against the code: the call_errors accounting, the twin and control swap in tools preference, same_choice_rate, the reach diff noise floor and the −0.42 / −0.20 figures all match. Two nits inline.
What I ran, on a Linux review host at fa9e5d2:
make ci-local: 25 passed, 1 failed, 6 skipped; 6,715 tests passed. The one failure ispip-auditreporting CVE-2026-113722 invirtualenv21.14.7 (a dev tool), fixed onmainby #152; the PR touches no dependency.mkdocs build --strict: no warnings.test_docs_links.pyandtest_docs_code_refs.py: 50 passed.#pinning-samplingandtool-preference.mdresolve.
Checked, no issues
- Claims:
agent_runner.pykeeps a malformed call with itserror, counts it incall_errors, and leaves it out ofcalled_tools,skill.loadedand the other counters. - Numbers: −0.42 and −0.20 match
tool-preference.md:129-130; thetemperature=1sentence matchesbenchmarking-and-comparison.md. - Repo rules: the page is already in
nav:, no schema or package change, so no changelog fragment is needed.
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM. I pushed a commit per nit, up to a91e6b5, which fix the two nits from my review:
a67d570:dokimi/docs/evaluating-treatments.md:595: the repeat flags are nowtools preference --reps 3andreach eval --attempts 3, and the other proxies are told to repeat the run.a91e6b5:dokimi/docs/evaluating-treatments.md:578: dropped "and in which turn" from the trace list and added where the turn is recorded.
make ci-local at a91e6b5: 25 passed, 1 failed (pip-audit, same as reviewed head), 6 skipped.
Summary
New subsection in
docs/evaluating-treatments.md, under Skill selection. It covers skills, MCP tools and function tools:NEXT_STEPS item 5b. Each rule points to something that already exists:
call_errors(#49),tool_preference.v1(#53), the temperature recipe (#46), and the proxy-vs-harness numbers intool-preference.md.Evidence
pytest -k "doc or link or markdown": 462 passed. This includestest_docs_links.py, which checks the#pinning-samplingandtool-preference.mdlinks.agent_runner.py:134says a failed call is counted only incall_errors.Merge Danger
Door: two-way
Docs only.
Blast Radius: none
🤖 Generated with Claude Code