Repository navigation
Conversation
Passes --allow-unsupported to repo tasks check, so a task whose task.json host requirements the runner misses passes its job. Off by default. Part of intel#41. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 91.40% 91.54% +0.13%
==========================================
Files 216 222 +6
Lines 26741 27369 +628
Branches 4377 4505 +128
==========================================
+ Hits 24442 25054 +612
- Misses 1635 1644 +9
- Partials 664 671 +7 🚀 New features to boost your workflow:
|
antonwolfy
left a comment
There was a problem hiding this comment.
Review at 7d5e00a. The workflow change itself is right and small. The PR also adds dokimi/uv.lock (6,890 lines, 1.4 MB), which breaks CI. One thing to fix before merge.
What I ran, on a Linux review host at 7d5e00a:
make ci-local: 23 passed, 3 failed, 6 skipped. One failure is the PR's (the large-file hook). The other two do not come from this diff:pip-auditreports virtualenv 21.14.7 (CVE-2026-113722) from the existing locks (fixed onmainby #152), andtest_unbalanced_quote_in_hook_completes_quicklytook 1.002 s against a 1 s limit (6,714 other tests passed).- zizmor on
repo-eval.yml: no findings.
dokimi/uv.lock should not be in this PR. It is unrelated to the allow-unsupported input, and it fails CI as it stands.
check-added-large-files --enforce-all(.pre-commit-config.yaml:41) fails:dokimi/uv.lock (1377 KB) exceeds 500 KB.- The license-header check covers
**and ignores only the threerequirements*.lock.txtfiles (.github/.licenserc.yaml:45-47).uv.lockstarts withversion = 1and has no SPDX header: GitHub's Static checks job fails on it ("the following files don't have a valid license header: dokimi/uv.lock"). - The repo's locks are the hashed
requirements*.lock.txtfiles, whichtests/test_dependency_locks.pyand Renovate (renovate.json5:54) cover. Nothing generates, checks or installs from auv.lock, so it would drift unnoticed.
Suggestion: drop the file from the PR (git rm dokimi/uv.lock). If a uv lock is wanted, do it in its own PR with the header, the ignore entries and a check.
Checked, no issues
- Step script:
flags=()with"${flags[@]}"expands correctly. The input arrives throughenv, as the stringtrueorfalse, so[ "$ALLOW_UNSUPPORTED" = true ]works. Nothing is interpolated intorun. - Behaviour claims:
repo_run.py:152-159lets onlyunsupported_by == "host"pass. Broken tasks andhost-proberesults still exit 1, as the changelog and docs say. - Default: the input is under
workflow_callonly, defaults tofalse, so existing callers are unchanged.
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Summary
tasks-check job: repo tasks check flags=() if warm: flags+=(--warm) + if allow-unsupported: flags+=(--allow-unsupported)New boolean input
allow-unsupported(default false). A task whose task.jsonhostblock (D3, #112) the runner misses passes its job; broken tasks and failed host probes still fail (CLI semantics unchanged). Caller: oneDAL #3818fix_cel_thread_race(needs 4+ Intel CPUs; hosted runners may be AMD).Part of #41.
Evidence
--allow-unsupportedfrom a caller; an unsupported task fails its job, so oneDAL excludes the task.After:
allow-unsupported: trueadds the flag;pytest tests/test_repo_eval_task_selection.py37 passed.Merge Danger
Door: two-way
Blast Radius: none (opt-in input)
🤖 Generated with Claude Code