Skip to content

fix(migtd): report rebinding status accurately - #1100

Merged
jyao1 merged 1 commit into
intel:mainfrom
haitaohuang:fix/rebinding-status-reporting
Nov 2, 2026
Merged

jyao1 merged 1 commit into
intel:mainfrom
haitaohuang:fix/rebinding-status-reporting

Conversation

@haitaohuang

Copy link
Copy Markdown
Contributor

Summary

  • capture the result returned by ReportStatus after rebinding
  • log the actual notification outcome instead of unconditional completion
  • distinguish a successful rebinding operation from a subsequent reporting failure

Testing

Previously validated during branch preparation:

  • cargo fmt --check
  • cargo xtask lib-test --crates migtd
  • TLS and SPDM skip-RA EMU smoke tests
  • TLS rebind skip-RA test

@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from 679dbe9 to 5fde09f Compare October 27, 2026 11:57
@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from 5fde09f to 46664e0 Compare October 27, 2026 20:13
@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status note: the current failed checks are infrastructure failures, not patch failures.

  • Build (virtio-serial / v1 / tls / debug): runner disconnected during Checkout sources.
  • Build (vmcall-vsock / v1 / tls / release): runner disconnected during Checkout sources.

Neither job reached compilation or tests. The remaining checks are still progressing.

@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: Build (virtio-serial / v2 / spdm / release) also failed because the hosted runner lost communication during Checkout sources. It did not reach compilation or tests, so this is another infrastructure failure.

@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: two more matrix jobs failed because the hosted runner lost communication during Checkout sources:

  • Build (vmcall-vsock / v1 / tls / debug)
  • Build (vmcall-raw / v2 / tls / release)

Neither reached compilation or tests; these are additional infrastructure failures.

@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from 46664e0 to 089eed8 Compare October 28, 2026 04:09
@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update for the fresh run: Build (vmcall-raw / v1 / spdm / debug) lost hosted-runner communication during Checkout sources. It did not reach compilation, so this is another infrastructure failure. The final check is still running.

@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: the final check, Build (vmcall-vsock / v2 / tls / debug), also lost hosted-runner communication during Checkout sources. All 61 executed checks passed; neither failed matrix job reached compilation.

@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from 089eed8 to d8f5921 Compare October 28, 2026 07:38
@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update for the fresh run: Build (virtio-serial / v1 / spdm / debug) lost hosted-runner communication during Checkout sources. It did not reach compilation, so this is an infrastructure failure.

@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: Build (vmcall-raw / v2 / tls / debug) also lost hosted-runner communication during Checkout sources. It did not reach compilation, so this is another infrastructure failure.

@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: this attempt completed 61 checks successfully. Both failed matrix jobs lost hosted-runner communication during Checkout sources; neither reached compilation or tests.

@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from d8f5921 to f39943f Compare October 28, 2026 10:47
@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: Policy v2 Key Rotation (Mock Report) exceeded one hour in Checkout sources. Policy generation and the integration test never ran, so this is an infrastructure failure. Six checks remain active.

ReportStatus can fail after a rebinding operation completes, but the current path logs completion unconditionally. Capture and log the actual status-report result so diagnostics distinguish successful notification from a reporting failure.

Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Assisted-by: GitHub Copilot CLI:GPT-5.6 Sol
@haitaohuang
haitaohuang force-pushed the fix/rebinding-status-reporting branch from f39943f to deb3233 Compare October 28, 2026 14:58
@haitaohuang

Copy link
Copy Markdown
Contributor Author

CI status update: the final job, Build (vmcall-vsock / v1 / tls / debug), also failed during Checkout sources; compilation never began. The completed attempt had 61 successful checks and two infrastructure-only non-success jobs, so I retriggered CI with an unchanged-tree commit metadata refresh.

@jyao1
jyao1 merged commit c04e2e3 into intel:main Nov 2, 2026
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants