Repository navigation
fix(migtd/spdm): reject success status on error paths - #1097
Conversation
bd9b6e7 to
a5ee5f4
Compare
|
CI status note: the current failed checks are infrastructure failures, not patch failures.
No formatting, compilation, or test command ran in these failed jobs. The remaining checks are still progressing. |
a5ee5f4 to
9cbb1a6
Compare
|
CI status update for the fresh run: |
|
CI status update: two additional fresh-run jobs lost hosted-runner communication during
Neither reached build or test execution; both are infrastructure failures. |
|
CI status update: |
|
CI status update: the final failed job, |
9cbb1a6 to
e6eb8a8
Compare
|
CI status update: |
e6eb8a8 to
eeae764
Compare
|
CI status update: the final job, |
|
CI status update: |
|
CI status update: |
SPDM vendor-defined error responses carry an application status byte, but value zero maps to MigrationResult::Success. Decoding that value on an error path can therefore report a failed migration or rebind operation as successful. Centralize error-path decoding so Success and unknown values map to SecureSessionError, and cover direct decoding plus both SPDM conversion paths with zero application-status tests. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com> Assisted-by: GitHub Copilot CLI:GPT-5.6 Sol
eeae764 to
fd82e1f
Compare
|
CI status update: the final two jobs also failed during
The completed attempt had 59 successful checks and four infrastructure-only non-success jobs, so I retriggered CI with an unchanged-tree commit metadata refresh. |
Summary
MigrationResult::SuccessSecureSessionErrorTesting
Previously validated during branch preparation:
cargo fmt --checkcargo xtask lib-test --crates migtd