Repository navigation
Conversation
Contributor
Author
|
@haitaohuang @mingweishih |
haitaohuang
reviewed
Oct 27, 2026
| // Send our own signed CoRIM (if enrolled) so the peer resolves *our* | ||
| // current/init hashes through *our* authenticated mapping instead of | ||
| // theirs. Absent the `servtd_corim` feature, or when nothing is | ||
| // enrolled, send an explicit zero length. The peer must then use our JSON |
Contributor
There was a problem hiding this comment.
please update comments for non-corim case
Contributor
Author
There was a problem hiding this comment.
That code is not introduced by this patch.
This patch does not change existing CoRIM or non-CoRIM.
This patch only uses TLV format for the pre-session data.
I think non-CoRIM should be handled by #1087.
Contributor
There was a problem hiding this comment.
Ok. I can change that later.
Encode issuer chain, policyData and the optional TCB-mapping as type/length/value items (u32 type, u32 length); reject duplicates, unknown types and trailing bytes. Use pre-session version 0x0200. Signed-off-by: Jiewen Yao <jiewen.yao@intel.com> Assisted-by: Claude Code:claude-sonnet-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode issuer chain, policyData and the optional TCB-mapping as type/length/value items (u32 type, u32 length); reject duplicates, unknown types and trailing bytes. Use pre-session version 0x0200.
Fix #1088
Assisted-by: Claude Code:claude-sonnet-5-5