Skip to content

feat: positional argument for resource IDs#7

Merged
Patrik Simek (patriksimek) merged 4 commits intomainfrom
feat-positional-argument
Apr 24, 2026
Merged

feat: positional argument for resource IDs#7
Patrik Simek (patriksimek) merged 4 commits intomainfrom
feat-positional-argument

Conversation

@patriksimek
Copy link
Copy Markdown
Member

Summary

  • Upgrade @makehq/sdk to ^1.3.0; migrate imports from @makehq/sdk/mcp (MakeMCPTools / MakeMCPTool) to @makehq/sdk/tools (MakeTools / MakeTool).
  • Introduce a positional argument for resource-level actions driven by the new tool.resourceId field:
    • make-cli scenarios get 456 is equivalent to make-cli scenarios get --scenario-id=456.
    • Parent scopes stay as named flags, e.g. make-cli executions get <execution-id> --scenario-id=925.
    • Supplying both the positional and the flag is rejected; missing a required id prints a clear error.
  • Update AGENTS.md and README.md.
  • Bump CLI to 1.4.0.

Copilot AI review requested due to automatic review settings April 24, 2026 14:11
@patriksimek Patrik Simek (patriksimek) requested a review from a team as a code owner April 24, 2026 14:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI to use the newer @makehq/sdk/tools API and adds support for supplying a tool’s resource ID as an optional positional argument (backed by tool.resourceId), while retaining the existing long-form flags.

Changes:

  • Migrate tool imports from @makehq/sdk/mcp to @makehq/sdk/tools and bump @makehq/sdk to ^1.3.0.
  • Add positional resource-id support in command registration (deriveSelfIdentifier, positional arg parsing/validation, example rendering).
  • Expand tests and update documentation to describe the new positional behavior; bump CLI version to 1.4.0.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/index.ts Switch CLI entrypoint to MakeTools from the new SDK module.
src/commands.ts Implement positional resource-id support driven by tool.resourceId, including validation and example wiring.
src/examples.ts Extend example rendering to support emitting one key as a positional argument.
scripts/build-docs.ts Update docs generator for MakeTools and document positional arguments separately from options.
test/commands.spec.ts Add coverage for deriveSelfIdentifier and positional parsing/validation/help output.
README.md Document the new positional resource-id behavior and update examples/usage.
AGENTS.md Update agent guidance to reflect the tools import path and positional resourceId model.
package.json / package-lock.json Bump CLI version and SDK dependency/lockfile entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/examples.ts
Comment thread scripts/build-docs.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands.ts Outdated
Comment thread scripts/build-docs.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands.ts Outdated
@patriksimek Patrik Simek (patriksimek) merged commit 73a84bf into main Apr 24, 2026
4 checks passed
@patriksimek Patrik Simek (patriksimek) deleted the feat-positional-argument branch April 24, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants