feat: positional argument for resource IDs#7
feat: positional argument for resource IDs#7Patrik Simek (patriksimek) merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI to use the newer @makehq/sdk/tools API and adds support for supplying a tool’s resource ID as an optional positional argument (backed by tool.resourceId), while retaining the existing long-form flags.
Changes:
- Migrate tool imports from
@makehq/sdk/mcpto@makehq/sdk/toolsand bump@makehq/sdkto^1.3.0. - Add positional resource-id support in command registration (
deriveSelfIdentifier, positional arg parsing/validation, example rendering). - Expand tests and update documentation to describe the new positional behavior; bump CLI version to
1.4.0.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/index.ts |
Switch CLI entrypoint to MakeTools from the new SDK module. |
src/commands.ts |
Implement positional resource-id support driven by tool.resourceId, including validation and example wiring. |
src/examples.ts |
Extend example rendering to support emitting one key as a positional argument. |
scripts/build-docs.ts |
Update docs generator for MakeTools and document positional arguments separately from options. |
test/commands.spec.ts |
Add coverage for deriveSelfIdentifier and positional parsing/validation/help output. |
README.md |
Document the new positional resource-id behavior and update examples/usage. |
AGENTS.md |
Update agent guidance to reflect the tools import path and positional resourceId model. |
package.json / package-lock.json |
Bump CLI version and SDK dependency/lockfile entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
@makehq/sdkto^1.3.0; migrate imports from@makehq/sdk/mcp(MakeMCPTools/MakeMCPTool) to@makehq/sdk/tools(MakeTools/MakeTool).tool.resourceIdfield:make-cli scenarios get 456is equivalent tomake-cli scenarios get --scenario-id=456.make-cli executions get <execution-id> --scenario-id=925.AGENTS.mdandREADME.md.1.4.0.