fix: code signing on macOS#5
Merged
Patrik Simek (patriksimek) merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release automation to better support distributing macOS binaries by adding code signing/notarization steps, plus minor workflow gating adjustments and a patch version bump.
Changes:
- Add macOS code signing (Developer ID) and notarization steps to the release workflow.
- Add a macOS entitlements plist used during signing.
- Restrict publish-related jobs to
releaseevents and bump package version to1.3.1.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds codesign/notarytool steps, enables workflow_dispatch, and gates publish jobs to release events. |
build/entitlements.mac.plist |
Introduces entitlements used for macOS signing. |
package.json |
Bumps package version to 1.3.1. |
package-lock.json |
Updates lockfile version fields to match 1.3.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| on: | ||
| release: | ||
| types: [created] | ||
| workflow_dispatch: |
| --team-id "${APPLE_TEAM_ID}" \ | ||
| --password "${APPLE_APP_PASSWORD}" \ | ||
| --wait | ||
|
|
Comment on lines
+5
to
+14
| <key>com.apple.security.cs.allow-jit</key> | ||
| <true/> | ||
| <key>com.apple.security.cs.allow-unsigned-executable-memory</key> | ||
| <true/> | ||
| <key>com.apple.security.cs.disable-executable-page-protection</key> | ||
| <true/> | ||
| <key>com.apple.security.cs.allow-dyld-environment-variables</key> | ||
| <true/> | ||
| <key>com.apple.security.cs.disable-library-validation</key> | ||
| <true/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release workflow to add automated code signing and notarization for macOS binaries, ensuring that distributed binaries are trusted by macOS Gatekeeper. It also adds a new entitlements file for signing, restricts certain jobs to only run on release events, and bumps the package version.
macOS Code Signing and Notarization:
.github/workflows/release.yml) to import the Apple Developer ID certificate, sign the macOS binary with entitlements, and notarize the binary using Apple’s notary service. This ensures that users won’t see security warnings when running the CLI on macOS.build/entitlements.mac.plist) specifying required code signing permissions for the macOS binary.Workflow Improvements:
workflow_dispatchto the release workflow, allowing manual triggering of releases in addition to automatic triggers.build-deb,release, andupdate-homebrewjobs to only run for actual release events, preventing accidental runs on other workflow triggers. [1] [2] [3]Other:
package.jsonfrom1.3.0to1.3.1.