Rename checkpoint trigger file to be product-agnostic#704
Merged
Conversation
The on-demand checkpoint sentinel file in /dev/shm was named "instructlab_checkpoint_requested" — rename it to the generic "checkpoint_requested" so the mechanism is not tied to a specific product name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe trigger filename for on-demand checkpointing is renamed from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Read CHECKPOINT_TRIGGER_FILENAME from os.environ at call time in _get_trigger_path() instead of using a module-level constant. This lets users customize the trigger filename for environments where multiple training jobs share the same /dev/shm. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Maxusmusti
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instructlab_checkpoint_requestedtocheckpoint_requestedso it is not tied to a specific product name.CHECKPOINT_TRIGGER_FILENAMEenvironment variable.Test plan
test_on_demand_checkpoint.pypass (including new env var override test)🤖 Generated with Claude Code