Closed
Conversation
|
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
fix/pre-commit-job
branch
from
5af428c to
2927b01
Compare
pvital
reviewed
Apr 13, 2026
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
IMHO, the main goal of pre-commit is to run before you commit locally during your development to fix all missed project practices. I don't see any value in doing that in the CI pipeline.
If you want to validate the project rules for a PR, I suggest you create a GitHub Action to execute Ruff, pointing out the necessary errors (like SonarQube does), and blocking the merging. I started something before here that you can use as a source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.