You cannot get_data_from_shared_memory if data is an error report#162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with a camera via shared memory, any issue should be reported as a tuple of 500 i.e. error code and code description. However, in the current version of the code, if using shared memory is True, the (500, ErrorCode) would be interpreted as instruction for shared memory rather than an error code. Consequently, the error displayed would be along the lines of "cannot interpret (500, ErrorCode) tuple as dict" rather than the actual error that happened on the camera. This PR fixes this little issue, which is especially important when debugging the emulator. With this fix, errors are passed to the main GUI correctly, even if using shared memory is True.