This repository was archived by the owner on Feb 15, 2025. It is now read-only.
Set default hostname to 'localhost' for webpackServer#546
Open
mradenovic wants to merge 1 commit intoinsin:masterfrom
Open
Set default hostname to 'localhost' for webpackServer#546mradenovic wants to merge 1 commit intoinsin:masterfrom
mradenovic wants to merge 1 commit intoinsin:masterfrom
Conversation
When a hostname is not provided, a user is shown a message `The app is running at HTTP://localhost:3000/`. This, however, is not always correct. If the development is done within the crostini container, the default hostname will be `http://penguin.linux.test:3000/'. Setting the default hostname to 'localhost' makes everything work out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hostname is not provided, a user is shown a message
The app is running at HTTP://localhost:3000/. This, however,is not always correct. If the development is done within the crostini
container, the default hostname will be
http://penguin.linux.test:3000/.Setting the default hostname to
localhostmakes everything work out of the box.