feat: allow cross projects zone access - #85
Conversation
0c132c0 to
19ab4a9
Compare
abhijith-darshan
changed the title
b6d64cd to
5d42cc8
Compare
5d42cc8 to
4c22d39
Compare
4c22d39 to
33e5f25
Compare
33e5f25 to
1f55541
Compare
Includes zones AllProjects support (#3802) and SudoTenantID fix (#3808). Pin to post-v2.13.0 pseudo-version for recordsets AllProjects support (#3844).
Breaking change in gophercloud/v2 v2.13.0 — NewDNSV2 no longer accepts a context.Context parameter.
gophercloud v2 branch keeps Delete signature unchanged; DeleteWithOpts is the new function that accepts header opts including AllProjects.
1f55541 to
1b7a3e2
Compare
frittentheke
left a comment
frittentheke
left a comment
There was a problem hiding this comment.
Thanks @abhijith-darshan for keeping at this and especially for going the extra mile to implement this in Gophercloud, the right place!
This chance looks good so far.
Since this s feature that needs integration testing, would you mind creating a devstack test for it? I know the current integration testing at https://github.com/inovex/external-dns-openstack-webhook/blob/main/.github/workflows/devstack.yml#L72-L109 is quite simple, but we already have devstack running ... it's just about marking use of it to ensure things work as they should with later changes.
3dce28f to
58cf282
Compare
I can try. Should this be a separate workflow or extend the existing one with a separate job or add additional step? |
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
|
@frittentheke how does this look? added webhook server and status server addr flags so that they can be configurable. Otherwise in the test we would have to kill existing running webhook. Also noticed the designate-worker fix was removed by you in the past - 3b52507 we just needed the abs path after [DEFAULT] and looks like the test time also reduces by 8 - 9 mins approx. |
|
Sorry about the delay @abhijith-darshan ! I shall try to look into this soon. |
Knalltuete5000
left a comment
Knalltuete5000
left a comment
There was a problem hiding this comment.
Minor details for the devstack but LGT
| - name: Wait for zone creation | ||
| run: | | ||
| while [ "$(openstack zone list -f csv | grep PENDING)" != "" ]; do date; openstack zone list -f value; sleep 1; done | ||
| while [ "$(openstack zone list -f value | grep PENDING)" != "" ]; do date; openstack zone list -f value; sleep 1; done |
There was a problem hiding this comment.
When changing this either way why not only list the zones in the desired status.
The openstack cli does support filtering by status
openstack zone list -f value --status PENDING
| - name: Wait for PENDING | ||
| run: | | ||
| while [ "$(openstack zone list -f csv | grep PENDING)" != "" ]; do date; openstack zone list -f value; sleep 1; done | ||
| while [ "$(openstack zone list -f value | grep PENDING)" != "" ]; do date; openstack zone list -f value; sleep 1; done |
There was a problem hiding this comment.
Same as above filter directly by status
3 participants
closes #83