Repository navigation
fix: use the only timetable source that has data - #15
Merged
Merged
Conversation
auto merge was overlaying an empty or cancelled-only grid onto the source that actually had periods. If only one of Comcigan or NEIS has subjects, return that result as-is. Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
injoon5
marked this pull request as ready for review
August 21, 2026 07:19
Empty or cancelled Comcigan periods fill from NEIS when it has a subject. Teachers, bell times, and homeroom still come from Comcigan when present. Both-have-data still uses shorter-name merge. Co-authored-by: Injoon Oh <injoon5@icloud.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source=autoalways merges. It does not pick one upstream wholesale.Merge rules
토요휴업일)source=autostill 409s if Comcigan’s search is ambiguousTests
Unit coverage in
src/test/timetable-merge.ts: empty grid fills periods but keeps Comcigan metadata; cancelled period fills from NEIS subject and keeps the Comcigan teacher.