Repository navigation
refactor: optimize API, harden client, fix docs/CI issues - #13
Merged
Merged
Conversation
API (src/): - Mask unknown/internal errors behind a generic 500 and log server-side instead of leaking error.message to clients - Remove `credentials: true` from CORS (public, unauthenticated API) - Make CORS origins env-overridable and add docs.timefor.school - Drop the redundant handleRoute wrapper (onError already maps errors) - Remove dead validation on /school and duplicate manual validation on /timetable (Typebox schemas already enforce it) - Filter /classes by current academic year to avoid stale class names - Use a total-order comparator for class sorting - Consolidate NEIS client construction behind createNeisClient() - Centralize the version string (API_VERSION) across / and OpenAPI - Allow array-valued error `details` in the schema (matches actual bodies) - Drop minItems:1 from list schemas so empty results don't 500 - Fix self-contradicting school example; simplify meal <br/> stripping Client (packages/client/): - Add fetch timeouts (AbortSignal.timeout) to NEIS and Comcigan requests - Fix teacher-index decoding (% 1000 to match the /1000 subject radix) - Cache the Comcigan /st code table (TTL) to cut a scrape per request - Harden Comcigan parsing (guard 학교검색, matrix/list fields, NaN) - Raise default NEIS pSize to 1000; correct the key doc comment - Remove needless structuredClone of freshly-parsed homeroom data Docs / CI / repo: - Fix GitHub source links (apps/docs/ path prefix) - Least-privilege workflow permissions + concurrency guard on auto-commit - Untrack .idea/, .vscode/, and the local timetable.json dump; gitignore them - Regenerate OpenAPI spec Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016iMMfLu3hPuAoBvaJbNfff
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_016iMMfLu3hPuAoBvaJbNfff