Fix lyrics view event handling and stale closure in AMLL player

desktop/src/renderer/components/LyricsView.tsx

@@ -39,6 +39,8 @@
   const animated = mapped.synced && !plain;
   const stampRef = useRef(stamp);
   stampRef.current = stamp;
+  const mappedRef = useRef(mapped);
+  mappedRef.current = mapped;
 
   // Create/destroy the DOM player for synced tiers.
   useEffect(() => {
@@ -51,18 +53,20 @@
     p.setWordFadeWidth(0.5);
     host.current.replaceChildren(p.getElement());
     player.current = p;
+    // AMLL re-dispatches DOM clicks on a line as "line-click" (not "click").
     const onClick = (e: Event) => {
       const ev = e as LyricLineMouseEvent;
-      const line = mapped.lines[ev.lineIndex];
-      if (line) bridge().dispatch({ type: "seekTo", data: { position_ms: Math.max(0, line.startTime - mapped.offsetMs) } });
+      const m = mappedRef.current;
+      const line = m.lines[ev.lineIndex];
+      if (line) bridge().dispatch({ type: "seekTo", data: { position_ms: Math.max(0, line.startTime - m.offsetMs) } });
     };
-    p.addEventListener("click", onClick);
+    p.addEventListener("line-click", onClick);
     return () => {
-      p.removeEventListener("click", onClick);
+      p.removeEventListener("line-click", onClick);
       p.dispose();
       player.current = undefined;
     };
   }, [animated, variant]);
 
   useEffect(() => {
     const p = player.current;
@@ -71,7 +75,7 @@
     p.setLyricLines(mapped.lines as never, extrapolate(stampRef.current, Date.now(), clockOffset, duration));
     p.setCurrentTime(extrapolate(stampRef.current, Date.now(), clockOffset, duration), true);
     p.update(0);
   }, [mapped, batterySaver, animated]);
 
   // Seek detection: a jump in the stamp means isSeek=true so AMLL relayouts.
   const lastStamp = useRef(stamp);