Fix CI: clippy 1.98 lints, Android SDK setup, racy pre-buffer test - #2
Merged
Merged
Conversation
Rust 1.98's clippy flags manual slice fills, drain-collect and a sort_by that sort_by_key covers. setup-android@v3 installs the legacy `tools` package by default, which sdkmanager can no longer find. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2aJfyqNAu3fSdazYDjPQ3
sdkmanager has no `platforms;android-37`; SDK 37 platforms carry a minor version, and the modules set compileSdk 37 with compileSdkMinor 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2aJfyqNAu3fSdazYDjPQ3
pre_buffer_is_reused_by_a_matching_load failed on a busy CI runner: the 1 s pre-buffer load can finish before the test even sends the discard, and reporting it then is correct. Only reports after the engine has handled the discard now count, marked by a seek's synchronous Position report. The check still fails if discard stops dropping the late load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2aJfyqNAu3fSdazYDjPQ3
ingoau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets CI green again on
main. Rust core and Android were both red; Desktop was already green.Rust core: clippy (Rust 1.98)
biquad,loudness,normalise): manual zeroing loops →.fill(..)(manual_slice_fill).connect/engine.rs:self.inbound.drain(..).collect()→std::mem::take(&mut self.inbound)(drain_collect).core/queries.rs: descendingsort_by→sort_by_key(|t| Reverse(t.play_count))(unnecessary_sort_by).All behaviour-preserving.
Rust core: flaky test
pre_buffer_is_reused_by_a_matching_loadfailed on a busy runner. The 1 s pre-buffer load could finish before the test even sent the discard, and reporting it at that point is correct. The test now only counts reports after the engine has handled the discard. The barrier is a seek's synchronousPositionreport. It passed 30/30 runs with the CPU saturated, and it still fails if discard stops dropping the late load.Android: CI setup
setup-android@v3asked for the legacytoolspackage by default, and the SDK repository no longer serves it. Nowpackages: platform-tools.platforms;android-37doesn't exist. SDK 37 platforms carry a minor version, and the modules usecompileSdk 37/compileSdkMinor 1, so it's nowplatforms;android-37.1.CI is green on the head commit: Rust core, Desktop and Android (Gradle unit tests, assemble and lint).
🤖 Generated with Claude Code
https://claude.ai/code/session_01F2aJfyqNAu3fSdazYDjPQ3