Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Arista switches leave MAU-MIB media empty or report an unrecognized OID while ENTITY-MIB describes the installed optic. This ports the released Community IX implementation into current upstream as an optional fallback in the existing switch poll.
Disabled by default; explicit switch-ID allowlist and Arista vendor match required. Valid MAU classifications take precedence. Exact Ethernet interface or immediate physical parent matching only; unknown/conflicting descriptions are ignored. Empty inventory and polling failures are distinguished, with generic error logging and retention of known media during failed discovery when MAU is empty.
Source: https://github.com/repstein2/ixpmanager-optical-discovery
Validation: applied cleanly to upstream main f130d66; PHP 8.3.6 syntax checks and all 21 synthetic checks passed in an isolated development directory; git diff --check passed. Full upstream PHP 8.4 PHPUnit/Psalm suites have not been run for this submission. The mapping regression tests a copy of the algorithm, not the database-backed Switcher integration.
Historical release validation: IXP Manager 7.3.1, 28 Arista switches at three Community IX exchanges, 204 previously empty classifications populated without unexpected identity/count/index/speed changes in recorded baselines. This is not live validation of the upstream revision. Physical removal, OSFP, IPv6-only SNMP and 800G/1.6T hardware remain unvalidated.
Separate from #1190, which hardens diagnostic sensor/error handling. No database migration, endpoint or template change.
CLA/public key emailed to operations@inex.ie November 7; acknowledgement pending. Companion documentation PR to follow.