Repository navigation
Conversation
afk11
force-pushed
the
expunge-pp-fixup
branch
3 times, most recently
from
October 28, 2026 08:45
9625071 to
b687e0b
Compare
afk11
force-pushed
the
expunge-pp-fixup
branch
from
October 28, 2026 13:11
b687e0b to
7bec134
Compare
afk11
force-pushed
the
expunge-pp-fixup
branch
from
November 9, 2026 10:38
7bec134 to
0c141d1
Compare
The Patch Panel expunge feature was attempting to delete files with the wrong storage path, and so left them on the filesystem. This commit fixes the filesystem path, and adds other improvements: - remove unnecessary code (copy paste relic) - forbid expunging an active patch panel (must be deactivated first) - split file delete from SQL updates, and wrap updates in a transaction - for expunge form, query for port count, file count, history count, history file count.. instead of looping and n+1 queries in view - add 'scopeForPatchPanel' on related models to avoid repeating whereHas over relations - reword deactivate patch panel dialog (don't mention delete) - basic feature test of expunge form and expunge handler
afk11
force-pushed
the
expunge-pp-fixup
branch
from
November 9, 2026 10:46
0c141d1 to
5a94dec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch panel expunge feature is currently not deleting the files associated with the patch panel. When I looked further I noticed a few other areas for improvement
Expungebutton is hidden until the patch panel is deactivated, so the form + POST endpoint redirect away if the patch panel isactive.minor:
Related PR #1167 will provide a command to cleanup leftover files