Repository navigation
RFC8414 metadata locations - #32
Merged
Merged
Conversation
…n issuer IndieAuth requires the issuer to be a prefix of the metadata URL. RFC 8414, which the next IndieAuth draft follows, places the document at https://host/.well-known/oauth-authorization-server followed by the issuer's path, so an issuer with a path is never a prefix of it and servers such as IndieKey.id were refused with "Issuer in metadata endpoint is not valid". _isIssuerValid() now accepts either form: the prefix rule as before, or the metadata URL equal to one of the issuer's RFC 8414 locations (the oauth-authorization-server and openid-configuration document names). The https, query and fragment checks are unchanged. Client::wellKnownMetadataURLs() builds the locations and is public for clients that want to explain a refusal.
…n issuer IndieAuth requires the issuer to be a prefix of the metadata URL. RFC 8414, which the next IndieAuth draft follows, places the document at https://host/.well-known/oauth-authorization-server followed by the issuer's path, so an issuer with a path is never a prefix of it and servers such as IndieKey.id were refused with "Issuer in metadata endpoint is not valid". _isIssuerValid() now accepts either form: the prefix rule as before, or the metadata URL equal to the issuer's RFC 8414 location. The https, query and fragment checks are unchanged. OpenID Connect discovery documents are not accepted; they follow their own rules and are not IndieAuth metadata. Client::wellKnownMetadataURL() builds the location and is public for clients that want to explain a refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.