Repository navigation
fix(deploy): verify Dragonfly Registry access after rollouts - #160
Conversation
iamWHTWD
left a comment
There was a problem hiding this comment.
I reviewed the chart and checker at 317ba889. The local test suite passed. The inline comments cover first-install Registry access, probe reliability, HTTPS and credential handling, and Helm upgrade behavior.
|
Reviewed head The companion-release design is useful: keeping Registry Deployment/PVC ownership separate, ANDing namespace and Pod selectors, restricting exec to configured Pod names, and advancing success state only after stable verification are sensible boundaries. The existing inline review tracks other ingress, transport, credential and operational concerns. I reproduced two additional compatibility issues to address alongside those threads before merging. R1 — [P2] Support the configured seed count rather than requiring exactly fiveBoth the chart and Reproduction:
Please accept a nonempty, duplicate-free configured list, require every listed seed to be present/Ready and to pass verification, and generate the same name-scoped exec RBAC from that list. Five can remain an example/default profile; installing a connectivity guard should not require expanding an existing three-seed deployment. Add positive three-/five-seed cases and negative missing, unready and duplicate-name coverage. R2 — [P2] Handle valid Registry blob redirectsThe curl invocation does not follow redirects, and the bootstrap read treats a non-200 response as a failed check. Blob redirects are part of the Distribution API, and the OCI specification allows redirects while restricting Authorization forwarding across host boundaries. A healthy redirecting/object-storage-backed Registry can therefore produce permanently failed guard Jobs. I exercised the actual
Please support bounded redirects with an explicit credential-forwarding policy and retain final digest/size validation. Also parse the final response body correctly: simply adding Validation and scopeThe existing 18 checker/chart tests, These were isolated local fixtures, not a live CNI/Kubernetes-exec or production rollout qualification. The reported five-seed production results do not cover a three-seed topology or a redirecting Registry. Please rerun the affected tests and CI on the resulting head after the fixes. Non-blocking follow-ups: add build/minimal-start coverage for the checker image and pinned dependencies, and distinguish proxy cache-hit verification from evidence of a fresh origin fetch. |
|
@rcyw R1/R2 are addressed in daf07fd: any nonempty unique seed list is supported with matching exec RBAC, and blob redirects are bounded with cross-origin credentials stripped and final digest/size checks retained. Three-/five-seed and direct/proxy redirect regressions pass. Latest head f5f6c22 has 27 passing local tests after deduplication; CI is running. Cache-hit scope is clarified in the README; image build/minimal-start automation remains a non-blocking follow-up. |
|
Re-reviewed head Compatibility fixes verified
I also checked the source changes and regressions corresponding to the other review threads: NetworkPolicy is opt-in with an existing-client review requirement; empty/invalid port lists fail; curl exit status is checked independently of HTTP status; HTTPS proxy trust is explicit; proxy probes require verified credential-safe logging; Helm no longer initializes the Job-owned state field; and response/decompression limits plus two-seed concurrency bound the workload. Validation
The production checker is reported suspended after unsafe proxy INFO logging was discovered. Production proxy checks still require verified logging/redaction and CA prerequisites; code approval does not qualify or resume that deployment. This review did not perform live CNI enforcement, a Helm 4 upgrade, a production rollout, or peak-RSS qualification. The documentation distinguishes those boundaries and cache-hit verification from a fresh origin fetch. Checker-image build/minimal-start automation remains a non-blocking follow-up. |
rcyw
left a comment
There was a problem hiding this comment.
Approving verified head f5f6c22c96b4b15c8fc557002cdeb2eca60f9074. R1/R2 from my earlier review are resolved; the 27 focused tests, four independent reproduction assertions, Helm lint and deployment syntax checks passed. CI 42994713646 is green on this head's merge with develop@b581532.
See the detailed re-review and validation results, including the production logging/CA prerequisites and qualification limits. Checker-image build/minimal-start CI remains non-blocking. No merge performed.
Registry relocation can block Dragonfly image preparation when ingress relies only on CIDRs. This adds a companion Helm release for precise seed ingress and automatic authenticated Nydus verification, while leaving Registry Deployment/PVC ownership with its existing deployment.
The guard detects Registry/seed identity changes and checks every configured seed (including three- and five-seed profiles). Success is recorded only after all seeds pass and the identities remain stable. Policy creation is opt-in after reviewing existing client ingress. Curl failures, bounded redirects, cross-origin credential stripping, HTTPS proxy trust, credential-safe logging prerequisites and response/decompression limits are enforced. Helm leaves the Job-written state field uninitialized.
Validation:
Operational limits: asynchronous post-rollout verification, not a readiness gate or automatic rollback. Proxy probes require verified request-log redaction/suppression. The production checker was suspended when unsafe INFO logging was found; this PR does not roll Registry/Dragonfly or resume that job.