test(audience-sample): pin frame rate to 1 on Linux for llvmpipe fill rate#762
Closed
ImmutableJeffrey wants to merge 1 commit intochore/sdk-318-linux-playmode-xvfbfrom
Closed
Conversation
Collaborator
Author
|
Closing without merging. Render suppression made things worse: Unity 2021.3 cells went from 3-4 min to 8-11 min because Application.targetFrameRate=1 starved frame-paced test coroutines. Correct fix is the inverse - decouple test polling from frame pacing entirely. Pursuing that in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinuxRenderSuppression[SetUpFixture]gated onUNITY_STANDALONE_LINUX.Application.targetFrameRate = 1andQualitySettings.vSyncCount = 0for the duration of the suite, restored on teardown.Why
Tests assert on UI Toolkit's visual-element tree (layout state), not on rasterised pixels. Painting more frames between assertions doesn't help the assertions; it just spends llvmpipe CPU cycles on fragment fill. Capping at 1 fps lets the player do logic work at full speed while skipping most paint cost.
Experiment success criteria
🤖 Generated with Claude Code