Repository navigation
build: lint TOML with Tombi - #129
Draft
iloveitaly wants to merge 2 commits into
Draft
iloveitaly wants to merge 2 commits into
iloveitaly wants to merge 2 commits into
Conversation
Taplo is unmaintained, so format and lint TOML with Tombi in just, lefthook, and CI. Co-authored-by: Michael Bianco <mike@mikebian.co>
Use a **/*.lock glob so new lockfiles are skipped without listing each path. Co-authored-by: Michael Bianco <mike@mikebian.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TOML in this repo had no formatter or linter. Taplo is not maintained, so the check uses Tombi, which is actively released and covers format, lint, and schema checks.
Description
tombi = "latest", locked to 1.5.5 by the 14-day release-age setting) in.config/mise.dev.toml.just toml_lintandjust toml_lint_fix, and include them injust lintandjust fix.**/*.lockfile, plus vendored metadata under.config/mise/locks/. Leavepyproject.tomlin its existing key order souv addis not rewritten.Screenshots / Test
just toml_linton the repo:tombi format --checkexits 1 on an unformatted file ("pytest.toml" is not formatted) and exits 0 after the file is restored.A deliberately unformatted
web/mise.lockis ignored bytombi format --checkbecause of the**/*.lockexclude.Links