[DOM] Register ids of SVG and MathML elements in the HTML5 parser - #254
Closed
iliaal wants to merge 1 commit into
Closed
[DOM] Register ids of SVG and MathML elements in the HTML5 parser#254iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
getElementById() relies on the parser registering id attributes in the document ID cache. The lexbor bridge only registered them when the attribute was in the HTML namespace, so the ids of SVG and MathML elements were invisible. Sibling audit: dom_check_register_attribute_id() and php_set_attribute_id() handle runtime attribute creation and are namespace-correct already.
Owner
Author
|
Promoted upstream as php#23598. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dom\HTMLDocument::getElementById() missed ids of SVG and MathML elements because the lexbor-to-libxml2 bridge in the HTML5 parser only registered id attributes when they were in the HTML namespace, while SVG and MathML elements carry their id attribute in their own namespace. The bridge now also registers the id attribute for elements in the SVG and MathML namespaces so that getElementById() finds them just like it does for HTML elements. Runtime paths (setAttribute(), setIdAttribute()) already handled this correctly and were audited as unaffected.