Conversation
End-to-end tests with an LLM agent live in https://github.com/ignfab/geocontext-test. Remove test/integration/level2-agent, its helpers and vitest.e2e.config.mts, the test:e2e and verify:full scripts, the LangChain dev dependencies only they used, their documentation and the .env.e2e entry of .gitignore, which is regrouped by purpose.
esgn
added this to the
v0.10.x MCP and WFS Stabilization to improve reliability milestone
Comment on lines
-95
to
-102
| testName: "should find that Sivom swimming pool in Mondeville is the nearest pool to the LUX cinema in Caen, and that the walking distance is 29 minutes", | ||
| userInput: "Quel est le temps de marche exact entre le cinéma LUX, situé au sud-est de Caen, et la piscine la plus proche ?", | ||
| toolMode: "mcp", | ||
| requiredToolCalls: ["geocode", "gpf_search_types", "gpf_describe_type", "gpf_get_features", "distance"], | ||
| expectedResponseFragments: ["Sivom", "Mondeville"], | ||
| assertScenarioResult: ({ normalizedFinalMessage }) => { | ||
| expect(containsNumberInRange(normalizedFinalMessage, 25, 35)).toBe(true); | ||
| }, |
Contributor
There was a problem hiding this comment.
This test was added recently, so I don't think it was ported to geocontext-test. Did you check that it was the only one missed?
Member
Author
There was a problem hiding this comment.
nope, I just deleted everything ;)
So we need to compare everything between here and geocontext-test and make issues in geocontext-test.
Contributor
There was a problem hiding this comment.
Copied to ignfab/geocontext-test#38, so it is not blocking for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
test:e2eintegration tests.Related issues (if applicable)
Close #170
Motivation
End-to-end tests with an LLM agent live in https://github.com/ignfab/geocontext-test.
Implementation
Remove test/integration/level2-agent, its helpers and vitest.e2e.config.mts, the test:e2e and verify:full scripts, the LangChain dev dependencies only they used, their documentation and the .env.e2e entry of .gitignore, which is regrouped by purpose.
Testing
npm run build && npm run verify:fastChecklist