138/review and fix - #208
Merged
LionelZoubritzky-IGN merged 5 commits intoOct 2, 2026
Merged
Conversation
The distance tool used bdtopo-osrm while travel_time_filter isochrones use bdtopo-valhalla, so the two could disagree by up to 12% on walking times. Reuse TRAVEL_TIME_RESOURCE for the itinerary.
The rebase brought back "plus précise et coûteuse, précision à 1mm" instead of the 0.5 cm wording merged in #183, and the new ", " join produced "suivi :, `spherical`". Join the profile lines as before.
Rounding to the whole minute turned a 40-second walk into 1 or even 0 minutes.
`profile` always has a value (`spherical` by default), so "lorsqu'un profil est renseigné" was always true.
The spherical and ellipsoidal profiles already round to the centimeter; the itinerary passed the service value through as is.
LionelZoubritzky-IGN
approved these changes
Oct 2, 2026
LionelZoubritzky-IGN
merged commit Oct 2, 2026
3a10440
into
138/distance-tool_navigation_modes
6 checks passed
esgn
added a commit
that referenced
this pull request
Oct 2, 2026
…l` (#207) * feat: Implement itinerary services * feat: plug itinerary into distance tool * 138/review and fix (#208) * fix(itinerary): route with Valhalla, like the travel time isochrones The distance tool used bdtopo-osrm while travel_time_filter isochrones use bdtopo-valhalla, so the two could disagree by up to 12% on walking times. Reuse TRAVEL_TIME_RESOURCE for the itinerary. * fix(distance): restore the ellipsoidal precision lost in the rebase The rebase brought back "plus précise et coûteuse, précision à 1mm" instead of the 0.5 cm wording merged in #183, and the new ", " join produced "suivi :, `spherical`". Join the profile lines as before. * fix(distance): keep a tenth of a minute in the travel time Rounding to the whole minute turned a 40-second walk into 1 or even 0 minutes. * docs(distance): say which profiles return a travel time `profile` always has a value (`spherical` by default), so "lorsqu'un profil est renseigné" was always true. * fix(distance): round the itinerary distance to the centimeter The spherical and ellipsoidal profiles already round to the centimeter; the itinerary passed the service value through as is. --------- Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
carandpedestrianprofiles to thedistancetool (the two commits of #207), with the review fixes on top.Related issues (if applicable)
Supersedes #207
Motivation
Lets the LLM estimate a travel time on foot or by car between two points, consistent with the
travel_time_filterisochrones.Implementation
bdtopo-valhallareplacesbdtopo-osrm: it is the engine of the isochrones, so both report the same travel times (OSRM differed by 2 to 12%).timekeeps a tenth of a minute, anddistanceis rounded to the centimeter, like the other profiles.Testing
npm run verify:fastgreen.TODOs
Checklist