3.4.0 - Redis TLS and ACL authentication support - #4
Merged
Annotations
10 warnings and 10 notices
|
Run Mago Linter:
src/Resque/Resque.php#L209
Literal argument `true` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: true)`.
|
|
Run Mago Linter:
src/Resque/Resque.php#L145
Literal argument `true` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: true)`.
|
|
Run Mago Linter:
src/Resque/Resque.php#L364
Shell-style comments ('#') are not allowed.
>This is a shell-style comment
Help: Consider using double slash comments ('//') instead.
|
|
Run Mago Linter:
src/Resque/Resque.php#L354
Shell-style comments ('#') are not allowed.
>This is a shell-style comment
Help: Consider using double slash comments ('//') instead.
|
|
Run Mago Linter:
src/Resque/Resque.php#L349
Shell-style comments ('#') are not allowed.
>This is a shell-style comment
Help: Consider using double slash comments ('//') instead.
|
|
Run Mago Linter:
src/Resque/Event.php#L83
Call to `array_search` must enforce strict comparison.
>Function `array_search` relies on loose comparison which can lead to unexpected behavior
Help: Call the function `array_search` with the `$strict` parameter set to `true`.
|
|
Run Mago Linter:
src/Resque/Event.php#L79
Use of the `isset` construct.
>Ambiguous check due to `isset()` conflating existence and null comparison
`isset()` returns false for both unset variables and null values.
It is unclear whether you're checking for variable existence or non-null value.
Help: Use explicit null comparison (`!== null`) or the null coalescing operator (`??`).
|
|
Run Mago Linter:
src/Resque/Event.php#L61
Use of the `isset` construct.
>Ambiguous check due to `isset()` conflating existence and null comparison
`isset()` returns false for both unset variables and null values.
It is unclear whether you're checking for variable existence or non-null value.
Help: Use explicit null comparison (`!== null`) or the null coalescing operator (`??`).
|
|
Run Mago Linter:
src/Resque/Job/Job.php#L145
Use of the `isset` construct.
>Ambiguous check due to `isset()` conflating existence and null comparison
`isset()` returns false for both unset variables and null values.
It is unclear whether you're checking for variable existence or non-null value.
Help: Use explicit null comparison (`!== null`) or the null coalescing operator (`??`).
|
|
Run Mago Linter:
src/Resque/Job/Job.php#L131
Use of the `isset` construct.
>Ambiguous check due to `isset()` conflating existence and null comparison
`isset()` returns false for both unset variables and null values.
It is unclear whether you're checking for variable existence or non-null value.
Help: Use explicit null comparison (`!== null`) or the null coalescing operator (`??`).
|
|
Run Mago Linter:
src/Resque/Worker.php#L288
Avoid boolean flag parameters.
>This parameter acts as a boolean flag
>Boolean type declared here
Boolean flags often indicate a function has more than one responsibility, making it harder to understand and test.
Help: Refactor by splitting the function into two separate methods, each with a clear, descriptive name.
|
|
Run Mago Linter:
src/Resque/Worker.php#L262
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Worker.php#L169
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Worker.php#L146
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Resque.php#L365
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Resque.php#L355
Avoid `elseif` clauses.
>This `elseif` adds unnecessary complexity
Complex conditional chains can often be simplified by using early returns or a `match` expression.
Help: Refactor to use guard clauses (early returns) or a `match` expression for clarity.
|
|
Run Mago Linter:
src/Resque/Resque.php#L308
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Resque.php#L311
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Resque.php#L159
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
Run Mago Linter:
src/Resque/Resque.php#L69
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
background
wait
wait-all
cancel
parallel
Loading