Add generic platform#22
Open
last-g wants to merge 5 commits intoicfpcontest2020:masterfrom
Open
Conversation
last-g
commented
Jul 1, 2020
| # This is effectively required to build and link any other language executable | ||
|
|
||
| RUN apt-get update && apt-get install -y locales \ | ||
| build-essential openssl libssl-dev ca-certificates \ |
Contributor
Author
There was a problem hiding this comment.
questionable actually
beevee
reviewed
Jul 1, 2020
Member
|
I'm afraid it won't work, because we restrict Internet access during build. You should split your Dockerfile into two separate images:
You can refer to a nice working example here: https://github.com/icfpcontest2020/dockerfiles/tree/master/dockerfiles/bazel |
Member
|
Can we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This offers a generic platform that can be used to easily bootstrap any language or technology.
It provides both build-time extension point and run-time extension point.
It also provides a
prepare_build.shscript in attempt to make the build faster and cache friendly.This is a followup to the discussion in #11
Tested locally: