-
Notifications
You must be signed in to change notification settings - Fork 81
Detecting and fixing incorrect YAML samples #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.0
Are you sure you want to change the base?
Changes from all commits
94fa32e
12d7b9c
1639b92
1948433
a975f81
6e147db
46fada1
2ae328f
498fd99
003cd72
164a415
a37e1de
44e472a
1d9b356
c9a880c
19ca290
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,10 @@ | |
| continue-on-error: true | ||
| run: composer check-rector | ||
|
|
||
| - name: Run YAML snippet tests | ||
| continue-on-error: true | ||
| run: composer check-yaml | ||
|
|
||
| code-samples-inclusion-check: | ||
| name: Check code samples inclusion | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -83,7 +87,7 @@ | |
| - name: Log target branch code_samples usage | ||
| if: steps.list.outputs.CODE_SAMPLES_CHANGE != '' | ||
| run: | | ||
| git fetch origin | ||
| git fetch origin --depth=1 ${{ github.head_ref }} | ||
|
Check failure on line 90 in .github/workflows/code_samples.yaml
|
||
|
|
||
| git checkout origin/${{ github.head_ref }} -- tools/code_samples/code_samples_usage.php | ||
| php tools/code_samples/code_samples_usage.php ${{ steps.list.outputs.CODE_SAMPLES_CHANGE }} > $HOME/code_samples_usage_target.txt | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ auth.json | |
| yarn.lock | ||
| docs/css/*.map | ||
| .deptrac.cache | ||
| .phpunit.result.cache | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,7 @@ framework: | |
| to: | ||
| - dropped | ||
|
|
||
| // ... | ||
| # ... | ||
|
|
||
| ibexa: | ||
| repositories: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,14 +3,14 @@ ibexa: | |
| <scope>: | ||
| connector_raptor: | ||
| enabled: true | ||
| customer_id: ~ # Required | ||
| customer_id: "12345" # Required | ||
| tracking_type: client # One of: "client" or "server" | ||
|
|
||
| # Raptor Recommendations API key | ||
| recommendations_api_key: ~ # Required | ||
| recommendations_api_key: "your_api_key_here" # Required | ||
|
|
||
| # Raptor Recommendations API URL, optional, set by default | ||
| recommendations_api_url: '%ibexa.connector.raptor.recommendations.api_url%' | ||
| # Raptor Recommendations API URI, optional, set by default | ||
| recommendations_api_uri: '%ibexa.connector.raptor.recommendations.api_uri%' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo! |
||
| ibexa_connector_raptor: | ||
| # When enabled, tracking exceptions are thrown instead of being silently handled | ||
| strict_exceptions: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,11 +27,14 @@ Symfony Flex installs and activates the package. | |
| After an installation process is finished, go to `config/packages/security.yaml` and uncomment `ibexa_cdp` rule. | ||
|
|
||
| ```yaml | ||
| ibexa_cdp: | ||
| pattern: /cdp/webhook | ||
| guard: | ||
| authenticator: 'Ibexa\Cdp\Security\CdpRequestAuthenticator' | ||
| stateless: true | ||
| security: | ||
| firewalls: | ||
| # ... | ||
| ibexa_cdp: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was outdated - the new config was stolen from configuration provided when installing the project |
||
| request_matcher: Ibexa\Cdp\Security\RequestMatcher | ||
| custom_authenticators: | ||
| - 'Ibexa\Cdp\Security\CdpRequestAuthenticator' | ||
| stateless: true | ||
| ``` | ||
|
|
||
| Now, you can configure [[= product_name_cdp =]]. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,5 +42,4 @@ ibexa: | |
| type: | ||
| pp_express_checkout: | ||
| name: "Translated PayPal Express Checkout name" | ||
|
|
||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,5 +43,4 @@ ibexa: | |
| type: | ||
| strp_checkout: | ||
| name: "Translated Stripe Checkout name" | ||
|
|
||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added after I've noticed that this step takes 11 minutes in one of the runs:
https://github.com/ibexa/documentation-developer/actions/runs/25958230826/job/76308753865
with this change it's reduced to 36 seconds:
https://github.com/ibexa/documentation-developer/actions/runs/25958591368/job/76309740366?pr=3165