fix(localizedFormat): fall back to English formats for lowercase tokens - #3217
Open
shoutoutuoadi325 wants to merge 1 commit into
Open
shoutoutuoadi325 wants to merge 1 commit into
shoutoutuoadi325 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format('l')(andll,lll,llll) throwsTypeError: Cannot read properties of undefined (reading 'replace')when the current locale has noformatsobject, for example a custom locale registered viadayjs.locale(name, { name, weekdays, months })(allowed byPartial<ILocale>). Parsing has the same hole:dayjs('2/5/2018', 'l', locale)swallows the error and returns Invalid Date.Uppercase
L/LL/ ... already falls back toenglishFormats, so the lowercase variants should too. The last fallback becomest(formats[B] || englishFormats[B]), andformatsgets a{}default sincecustomParseFormatpasseslocale.formats, which can be undefined.Locales that do define
formatskeep deriving lowercase tokens from their own uppercase formats. Adding lowercase keys toenglishFormatsdirectly would shadow those with the US formats (eslwould become3/5/2024instead of5/3/2024).This covers the cases still reproducing in #2281: the
enrepro there was fixed by the extend-time patch, but any locale without aformatsobject still crashes.Test plan
formats:l/ll/lll/llllformat the same as moment (new test inlocalizedFormat.test.js)L,landl LTin such a locale returns the parsed date instead of Invalid Date (new test incustomParseFormat.test.js)npm test(all TZ variants, 100% line coverage threshold) andnpm run lintpass