fix: return NaN from diff() when an operand is an Invalid Date - #3216
Open
yu2971512385-ui wants to merge 1 commit into
Open
yu2971512385-ui wants to merge 1 commit into
yu2971512385-ui wants to merge 1 commit into
Conversation
`monthDiff` ended with `|| 0`, which collapses the `NaN` produced by an Invalid Date operand into `0`. As a result `diff(invalid, 'month' | 'quarter' | 'year')` (and their `float` variants) returned `0` instead of `NaN`, unlike every other unit and unlike moment.js. Compute the value once and only normalize `-0` to `0`, letting `NaN` propagate to `diff()` unchanged. Fixes iamkun#3186 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3186.
The bug
monthDiffinsrc/utils.jsends with|| 0:When one operand is an Invalid Date, the arithmetic is
NaN, andNaN || 0collapses it to0. So the month-based units silently return0instead ofNaN:Every other unit already returns
NaNfor an Invalid Date operand (they go through plain millisecond arithmetic), and moment.js returnsNaNhere too — so'month' | 'quarter' | 'year'are inconsistent.The fix
Compute the value once and only normalize
-0to0, lettingNaNpropagate todiff()unchanged:Behaviour for valid dates is unchanged (
-0is still normalized to0).Tests
Added a
Differencecase assertingdiffwith an Invalid Date operand isNaN(not0) formonth,quarterandyear, in both directions and for thefloatvariants. Verified it fails on the current source and passes with the fix.🤖 Generated with Claude Code