prefix sum - #204
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
任意次元（1D/2D ラッパー含む）の prefix sum 構築・クエリを提供する新規 prefix_sum クレートを追加し、競プロ用途の区間和取得を汎用化する PR です。
Changes:
- 任意次元の
PrefixSumBuilder/PrefixSumと、1D/2D の薄いラッパー API を追加 PrefixSumValueトレイトと、整数型向けの実装マクロを追加- 単体テスト（境界条件・panic ケース・非Copy型など）を追加
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/prefix_sum/src/lib.rs | 任意次元 prefix sum の実装・公開 API・テストを追加 |
| libs/prefix_sum/Cargo.toml | 新規クレートのマニフェストを追加 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+135
to
+138
| assert!( | ||
| self.shape.len() < usize::BITS as usize, | ||
| "rank is too large to enumerate query corners" | ||
| ); |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.