Repository navigation
Conversation
…, vite 8, vitest 4; refresh lockfile
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
README assertions differ from their extraction sources and cause the documentation consistency CI check to fail.
1 open finding
What changed in this PR
Updates quantity-formatting development tooling to reduce vulnerable dependencies while preserving runtime code and the supported core version range.
Changes:
- Upgrades core development dependencies, ESLint tooling, Vite, and Vitest.
- Adapts Sass configuration and tests to the upgraded tools.
- Refreshes API declarations and README examples.
| File | Description |
|---|---|
| packages/quantity-formatting/vite.config.ts | Removes explicit Sass compiler options. |
| packages/quantity-formatting/src/test/quantityformat/QuantityFormatPanel.test.tsx | Adds a typed callback mock. |
| packages/quantity-formatting/src/test/quantityformat/internal/StationBaseFactor.test.tsx | Focuses inputs before shortcut tests. |
| packages/quantity-formatting/src/test/quantityformat/FormatSample.test.tsx | Focuses inputs before shortcut tests. |
| packages/quantity-formatting/README.md | Adds assertions to format-set examples. |
| packages/quantity-formatting/package.json | Upgrades development dependencies and adds Sass. |
| packages/quantity-formatting/api/quantity-formatting-react.api.md | Refreshes React JSX return-type references. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
…pets extractions" This reverts commit aacacd5.
grigasp
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
@itwin/quantity-formatting-reactwas still building against core 5.3/5.4 and an@itwin/eslint-pluginthat pulls in the vulnerablebraces, sopnpm auditreported 83 findings for the package. This updates the dev tooling to match the rest of the repo and regenerates the lockfile. Shipped code doesn't change, and the supported core version range stays at^5.3.0.First of three stacked PRs: tooling (this one) → format editing fixes → package cleanup.
What
package.jsondevDependencies@itwin/eslint-plugin5.x pulled in vulnerablebraces. Moves to core^5.14.0, eslint-plugin 6.1.1, Vite 8, Vitest 4, and@vitejs/plugin-react6, and drops ESLint plugins that eslint-plugin 6 already includes.sass-embedded(devDependency)FormatPanel.scss.vite.config.tsFormatSample/StationBaseFactorQuantityFormatPanel.test.tsxmock typesvi.fn()more strictly, so the callback mock declares its signature.api/quantity-formatting-react.api.mdReact.JSX.Elementinstead ofJSX.Element. The types themselves didn't change.README.mdlearning-snippets, which failscheck-extractions. Synced so this stack passes CI.Core is pinned to
^5.14.0rather than 5.14.2 because 5.14.2 is newer than the repo's minimum package age allows.Audit
pnpm audit(all deps)pnpm audit --prod(what CI checks)All 5 remaining findings are dev-only:
serialize-javascriptanddiffvia@itwin/build-tools→ mocha,sprintf-jsvia API Extractor, andi18next-http-backendviacore-frontend→core-i18n. Fixing them here would need rootpnpm-workspace.yamloverrides that apply to every package, and theserialize-javascriptfix is a major version past what mocha expects. They belong upstream in itwinjs-core.Validation
tsc,pnpm lint,pnpm test(153/153),pnpm build,extract-api, andcheck-extractionsall pass.Nambot 🤖 (powered by claude-opus-5.5)