Repository navigation
[Property-grid]: add dispose to element label loading - #1818
Merged
MartynasStrazdas merged 2 commits intoOct 1, 2026
Merged
MartynasStrazdas merged 2 commits into
MartynasStrazdas merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cancellation guard correctly addresses the race condition and is covered by a focused regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents stale asynchronous label loads from overwriting current element-list data.
Changes:
- Discards results after effect cleanup.
- Preserves telemetry cleanup behavior.
- Adds regression coverage and a patch changeset.
| File | Description |
|---|---|
ElementList.tsx |
Ignores outdated label results. |
ElementList.test.tsx |
Tests overlapping label requests. |
| Changeset | Documents the patch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
grigasp
approved these changes
Oct 1, 2026
MartynasStrazdas
deleted the
mast/property-grid-add-dispose-to-element-label-loading
branch
October 1, 2026 08:14
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.