Repository navigation
Conversation
The library is referenced nowhere in the source code.
jomey
requested review from
a team and
brentwilder
and
a balanced review from Copilot
October 21, 2026 23:23
jomey
added
the
maintenance
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No source or workflow references require the removed dependency or dev extra, and no unresolved issues remain.
No open issues 🎉
What changed in this PR
Removes the unused spatialnc development dependency from topocalc as part of preparation for a Python upgrade.
Changes:
- Removes
spatialnc>=0.2.12and the now-emptydevoptional dependency group. - Leaves runtime dependencies unchanged.
| File | Description |
|---|---|
| pyproject.toml | Removes the optional development dependency configuration for spatialnc. |
Review effort: Balanced
No code upgrade needed and goes with the other upgrades to AWSM and SMRF.
All others are not used and this follows the other iSnobal components.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is referenced nowhere in the source code. Found this as part of the investigation what it takes to upgrade the python version.
For reference - this is where the library lives
https://github.com/USDA-ARS-NWRC/spatialnc