Repository navigation
Conversation
jomey
added
the
maintenance
jomey
changed the title
Hedrick-ARS
approved these changes
Oct 23, 2026
Hedrick-ARS
left a comment
Hedrick-ARS
left a comment
There was a problem hiding this comment.
Syntax cleanup and elimination of spatialnc dependency.
Looks like a winner.
Member
Author
|
To get the tests passing we first must work on an updated conda environment. |
When manually updating the snow depth for the time step, we need to ensure that the data type for snow depth matches the expected type for PySnobal. This means all arrays need to be of type float64.
The dedicated libray was removed as a dependency.
All differences where < 1e-5 with the execption of cold content of < 1. No update to snow.nc needed.
Was still pointing to the UofU Cryosphere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes due to Python upgrade
The gold files for RME needed recreation with mostly floating point differences.
Gold file changes
Changes due to PySnobal numpy upgrade
Only the lidar update logic needed a change when manipulating the snow states.
This is corresponding to the changes in PySnobal PR#23 and the gold files updates are below.
Once the PR is merged, the tests for AWSM need to be re-run and should be passing.
Gold file changes
All but the cold content are in the floating point noise range. The cold content is still < 1 J, which is the accumulated effect.
Snow
Energy & Mass