Repository navigation
fix: warn before discarding Direct credentials - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice 26 PR 2 only: require explicit confirmation before saving a switch away from a persisted Direct configuration with a saved pairing token. The warning covers local URL/token removal, cancellation preserving saved settings and pending edits, deliberate server rotation if the token is no longer available, and restart-only application.
Review found and fixed a stale-authorization gap: editing the Managed SSH target while the warning was open previously kept confirmation active.
Permanent regression coverage
ConnectionDialog.svelteinteraction tests cover all destination modes, cancellation and pending edits, explicit confirmation, deferred/concurrent saves, stale mode/target/settings changes, failed-save retry, Close/Escape, Direct preservation/replacement, and absence of a saved Direct credential.App → Hud → ConnectionDialogintegration test verifies saving does not reload runtime configuration, replace/close the active socket, restart the source, or change its active authentication token.Verification
npm run test --workspace @imp/desktop -- --project dom: 16 passed.npm run test --workspace @imp/desktop: 168 passed across 21 files.npm run check: passed, including all formatting/lint/docs/version checks, typechecks, suites, e2e and production build.git diff --check: passed.Scope and limitations
tunnel_config::testspreviously passed 26 tests; not rerun because native persistence is unchanged. Frozen server acceptance is not required for this renderer-only change.