Fix theta-search solver and polarization handling - #41
Merged
Merged
Conversation
… case generator Three fixes for the multilayer theta search: - The `Requested theta half-width ... reaches near/into 0 deg` notice leaked to the terminal from the spawned batch workers, which re-import grax but never call setup_logging, so the record fell through to logging.lastResort. Attach a NullHandler to the `grax` logger at import; setup_logging now also sets propagate=False and de-duplicates its file handler. The notice itself drops from WARNING to INFO and is emitted once per distinct (center, half-width) instead of on every rough/fine re-centring attempt. - multilayer_theta_search_cases gained `solver` / `solver_options`, matching run_multilayer_theta_search. The batch runner already honoured a per-case "solver" key; the generator just could not set one. - The multilayer_theta_search example takes --polarization alongside --solver and writes each run under results/<solver>_<polarization>/ so s and p runs no longer overwrite each other. Polarization and solver were already threaded through run_multilayer_theta_search(_sweep) and the web run form on develop; this closes the remaining gaps on that branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uv run pytest tests/unit tests/smoke --ignore=tests/unit/test_reticolopy_opt.py --cov=grax --cov-report=term-missing --cov-report=xml(462 passed, 5 skipped)