Single-pass replace_source / replace_destination - #90
Open
yinoneliraz wants to merge 1 commit into
Open
yinoneliraz wants to merge 1 commit into
yinoneliraz wants to merge 1 commit into
Conversation
Rewrite _replace_source_in_edges and replace_destination as plain single-pass loops (same shape as replace_nodes from CORE-30) instead of composed transform_edges passes, which iterated the edge set four times through curried per-edge closures. Removes the now-unused private edge-mapper helpers. Benchmark (bot-building workload, 4498 edges, 200 replaces): replace_source phase 2534ms -> 602ms; workload total 3141ms -> 1209ms. All tests pass; canonical output graphs identical to master. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
yinoneliraz
force-pushed
the
yinon/replace-source-single-pass
branch
from
July 12, 2026 09:50
c96a809 to
90f5aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite _replace_source_in_edges and replace_destination as plain single-pass loops (same shape as replace_nodes from CORE-30) instead of composed transform_edges passes, which iterated the edge set four times through curried per-edge closures. Removes the now-unused private edge-mapper helpers.
Benchmark (bot-building workload, 4498 edges, 200 replaces): replace_source phase 2534ms -> 602ms; workload total 3141ms -> 1209ms. All tests pass; canonical output graphs identical to master.