Improve Data hot-path performance with automatic execution recipes - #563
Merged
Conversation
Extract the built-in, backed-enum, and date conversion rules into one internal ValueCaster used by both ordinary casts and lean construction recipes. This keeps coercion behavior, date formats and timezones, concrete date targets, and existing exception contracts in one authoritative implementation without retaining cast instances in worker metadata.
Compile immutable per-class construction and transformation recipes from existing Data metadata, then select them automatically for supported runtime shapes while preserving the general engine as the single fallback. Reuse immutable default creation contexts, preflight complete nodes before conversion, share nested operation state, retain named-factory and hook boundaries, and keep bulk-copy transformation for plain objects. Unsupported declarations and ambiguous conversion families continue through the established path before construction. Defer PHPDoc parser setup when native types prove iterable metadata cannot apply. Add focused equivalence, fallback, metadata, lazy, partial, mapping, constructor, and transformation coverage so lean execution stays behaviorally identical to the general path.
Resolve DataCreator and DataTransformer from an application booted callback after all providers have configured their dependencies. Production workers inherit the initialized immutable service graph instead of making the first request pay that fixed setup cost. Keep unit-test applications on demand so repeated Testbench boots remain fast, and cover both testing and non-testing application lifecycles with stable instance assertions.
Expand the developer benchmark matrix across construction, validation, transformation, collections, resources, persistence, metadata, and first-use boundaries. Add a dedicated historical DataObject comparison harness under the test namespace so supported shapes can be measured against the removed mapper without restoring it as framework API. Document both commands and keep raw reports opt-in and outside the repository.
Record the measured baseline, immutable recipe design, one-engine fallback rules, lifecycle constraints, integration boundaries, test matrix, performance acceptance criteria, and rejected alternatives. The plan also preserves the required post-checkpoint merge and benchmark work so the current 0.4 enum and morph behavior is reconciled before final integration.
Bring the latest 0.4 framework changes into the automatic Data execution branch, including the first-party FormRequest casting redesign, shared enum coercion helpers, and the queue, database, validation, and lifecycle fixes already accepted on 0.4. Reconcile the Data fast path with the shared enum_from semantics so lean and general construction accept integer-backed numeric strings consistently. Preserve enum_try_from morph selection and add a focused regression that proves the compiled operation, target enum, and concrete result. Finish the execution terminology sweep, retain the measured performance and memory conclusions in the active plan, and record the completed verification state. The merged tree passes composer fix and focused Data, enum, FormRequest, and capability coverage; repeated benchmarks retain the material construction and transformation gains without a systematic fallback-path regression.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (27)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAutomatic lean execution is implemented for Hypervel Data. Immutable metadata recipes classify construction and transformation paths. Creation contexts and parser dependencies are cached selectively. Casting, transformation, provider warming, tests, and benchmark harnesses are updated. ChangesAutomatic lean execution
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: ⚪ Minimal · up to The optimized creation and transformation paths retain documented fallbacks and equivalence coverage, with no actionable merge-blocking issue identified. Sequence Diagram(s)sequenceDiagram
participant Caller
participant DataCreator
participant CreationContextFactory
participant ValueCaster
participant DataInstantiator
Caller->>DataCreator: create payload
DataCreator->>CreationContextFactory: get cached create context
DataCreator->>ValueCaster: convert typed property
DataCreator->>DataInstantiator: instantiate lean node
DataInstantiator-->>DataCreator: data instance
DataCreator-->>Caller: return created data
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 228 functions across 25 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes common
hypervel/dataconstruction and transformation paths substantially faster without adding a second data-object API or changing the public contract.Data classes now receive immutable execution recipes when their declarations can be handled safely by fixed operations. The runtime selects those recipes automatically. Classes using custom casts, normalizers, lifecycle hooks, validation, lazy values, partials, or unsupported union shapes continue through the existing general engine.
Motivation
The Data package supports validation, property mapping, nested objects and collections, lazy values, partial transformations, HTTP resources, request casting, and Eloquent persistence. Its general engine preserves all of those behaviors, but simple objects were paying much of that orchestration cost even when their declarations needed only fixed scalar, enum, date, or nested Data conversion.
The goal here is to make work proportional to the features a declaration uses. Applications should not need to choose a fast mode or a separate lightweight object type.
Design
Class metadata now records one of three transformation states: bulk copy, a fixed property recipe, or the general property loop. Construction similarly records a fixed recipe only for declarations whose behavior is known at metadata-build time.
The implementation:
ValueCaster, keeping lean and general behavior identical;factory()overrides, validation decisions, partials, transformation overrides, resource finalization, and persistence behavior;No public API changes are introduced.
from(),factory(),collect(),transform(),all(), andtoArray()retain their signatures and extension boundaries.Performance
Measurements used PHP 8.4.23 on Linux x86-64 with CLI OPcache and JIT disabled. Results are the median across three alternating fresh-process runs against the current
0.4branch. Each standard run used 2,000 operations, seven measured samples, and 100 warm-up operations.0.4p500.4p95AutoLazy, customized collection factories, lazy partials, Eloquent relation loading, and other fallback-heavy scenarios remained within run-to-run noise.
The tradeoffs are deliberately bounded:
The committed benchmark harness reports p50, p95, throughput, query counts, memory, environment details, and checksums. A separate historical comparison fixture remains isolated under
tests/Benchmarks/Dataand is loaded only by its developer benchmark command.Verification
composer fix, including formatting, static analysis, parallel tests, Testbench, and dogfood checks.Summary by CodeRabbit
New Features
Bug Fixes
Documentation