Skip to content

fix(asdf-monitor): bump ratatui 0.28 -> 0.30 (drops lru 0.12.5) - #219

Merged
hyperpolymath merged 1 commit into
mainfrom
deps/ratatui-0.30-issue96
Oct 5, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
deps/ratatui-0.30-issue96

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Refs hyperpolymath/.git-private-farm#96 (owner ruling D138: accept major dep bumps, fix breakage).

Change (asdf-augmenters/asdf-acceleration-middleware)

  • crates/asdf-monitor/Cargo.toml: ratatui 0.28 -> 0.30, crossterm 0.28 -> 0.29 (matches ratatui 0.30's crossterm backend; avoids two crossterm copies).
  • crates/asdf-monitor/src/main.rs: ratatui 0.30 gives Backend an associated Error type, so run_dashboard adds where B::Error: Send + Sync + 'static for anyhow's ?. Docstring added.
  • Cargo.lock: ratatui 0.30.2 / crossterm 0.29.0; lru 0.12.5 removed — only lru 0.18.4 remains (shared by asdf-cache and ratatui-core; cargo tree -i lru).

Verification (local, cargo 1.97.1)

  • cargo build -p asdf-monitor -> OK (same single pre-existing unused import: Path warning in asdf-core as main).
  • cargo test -p asdf-monitor -> OK, 0 tests (the crate has none).
  • cargo clippy -p asdf-monitor -> no new warnings.
  • Binary smoke: asdf-monitor --help and asdf-monitor health run. The interactive dashboard was not exercised (needs a real TTY).
  • cargo test --workspace fails identically on main (asdf-metrics lib tests: cannot find type Duration, E0433 x2) — pre-existing, unrelated to this change.

Alerts

Deferred red checks (non-required, fail identically on main)

🤖 Generated with Claude Code

ratatui 0.28 pulled lru 0.12.5 (GHSA-rhfx-m35p-ff5j, patched 0.16.3).
ratatui 0.30 (ratatui-core) uses lru 0.18, which unifies with the
workspace's direct lru 0.18.4; lru 0.12.5 is removed from the lock.

crossterm moves 0.28 -> 0.29 to match ratatui 0.30's crossterm backend.
ratatui 0.30 gives Backend an associated Error type, so run_dashboard
now bounds B::Error: Send + Sync + 'static for anyhow's `?`.

Refs hyperpolymath/.git-private-farm#96

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 5, 2026 22:26
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 28dac98d-13e9-4f20-8c2c-294c65e8c253
📥 Commits

Reviewing files that changed from the base of the PR and between 4341d6e and b8b1a44.

⛔ Files ignored due to path filters (1)
  • asdf-augmenters/asdf-acceleration-middleware/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • asdf-augmenters/asdf-acceleration-middleware/crates/asdf-monitor/Cargo.toml
  • asdf-augmenters/asdf-acceleration-middleware/crates/asdf-monitor/src/main.rs
 _________________________________________________________________________________________________________
< A good programmer is someone who always looks both ways before crossing a one-way street. - Doug Linder >
 ---------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • 🔴 Error committing to branch - (🔄 Check to retry)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Add Carrot credits or activate Agent usage billing to use Autopilot

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

❌ Failed to create Coding Agent finishing-touch task. Please try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant