Skip to content

feat: add logger configs to MultiModelTrainer#288

Open
Akshat105 wants to merge 1 commit into
hypernetwork-research-group:mainfrom
Akshat105:feat/add-configs-to-trainer
Open

feat: add logger configs to MultiModelTrainer#288
Akshat105 wants to merge 1 commit into
hypernetwork-research-group:mainfrom
Akshat105:feat/add-configs-to-trainer

Conversation

@Akshat105

Copy link
Copy Markdown

All submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there are no other open Pull Requests for the same changes?
  • Have you made sure you have rebased your branch to the latest commit on the target branch?

Description

Add markdown_logger_config and latex_logger_config parameters to
MultiModelTrainer so external users can customize the default
MarkdownTableLogger and LaTexTableLogger (e.g. precision, table caption,
sort order, borders) without providing a fully custom logger.

  • Add MarkdownTableConfig TypedDict with optional precision key
  • Add precision key to existing LaTexTableConfig TypedDict
  • Wire both configs through __setup_logger with backward-compatible defaults
  • Export MarkdownTableConfig from hyperbench.train
  • Add 7 unit tests covering defaults, custom values, partial overrides,
    and custom-logger bypass

Checklist

  • Does your submission pass all tests? (use make test)
  • Have you written tests to cover all your changes? If not, provide a reason.
  • Have you lint your code locally before submission? (use make format)
  • Have you type checked your code locally before submission? (use make typecheck)

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ddevin96

Copy link
Copy Markdown
Collaborator

hi @Akshat105, thanks for opening a PR!
Your PR helped us identity a small issue with the management of the token. We have pushed an issue to fix that, so if you rebase and include the changes, the test will act correctly.

We will also leave some comments in the PR In a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants