Repository navigation
docs: remove the DOMAIN step from the AKS walkthrough - #67
Open
jsturtevant wants to merge 1 commit into
Open
jsturtevant wants to merge 1 commit into
jsturtevant wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The domain-change instructions omit rerunning ly cluster install, leaving Knative routes and the ingress certificate configured for the old domain.
1 open issue
What changed in this PR
This documentation update addresses #35 by removing the domain requirement from the AKS walkthrough, allowing users to test a deployed service without configuring public DNS.
Changes:
- Removes the domain prerequisite,
DOMAINexport, anddomainconfiguration entry. - Tests the ingress IP using a placeholder
Hostheader taken from the Service URL. - Adds guidance for configuring a real domain later.
| File | Description |
|---|---|
docs/cluster-aks.md |
Simplifies domain-free AKS setup and updates service testing and optional DNS guidance. |
Review effort: Balanced
Comment on lines
+260
to
+261
| To use a real domain later, set `domain` in `azure.yaml` and create a wildcard | ||
| DNS record for `*.default.<domain>` pointing to the ingress address. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #35.
Removes the
DOMAINstep from the AKS walkthrough: the export, thedomain:line inazure.yaml, and the "domain you control" prerequisite. The test step now curls the ingress IP with aHostheader, and a note explains how to add a real domain later.The
Hostheader value is a placeholder (HOST_FROM_SERVICE_URL) taken from the URLly deployprints, since the default host name whendomainis unset was not verified.