Skip to content

docs: remove the DOMAIN step from the AKS walkthrough - #67

Open
jsturtevant wants to merge 1 commit into
hyperlight-dev:mainfrom
jsturtevant:fix-issue-35-domain-docs
Open

jsturtevant wants to merge 1 commit into
hyperlight-dev:mainfrom
jsturtevant:fix-issue-35-domain-docs

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Fixes #35.

Removes the DOMAIN step from the AKS walkthrough: the export, the domain: line in azure.yaml, and the "domain you control" prerequisite. The test step now curls the ingress IP with a Host header, and a note explains how to add a real domain later.

The Host header value is a placeholder (HOST_FROM_SERVICE_URL) taken from the URL ly deploy prints, since the default host name when domain is unset was not verified.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The domain-change instructions omit rerunning ly cluster install, leaving Knative routes and the ingress certificate configured for the old domain.

1 open issue
What changed in this PR

This documentation update addresses #35 by removing the domain requirement from the AKS walkthrough, allowing users to test a deployed service without configuring public DNS.

Changes:

  • Removes the domain prerequisite, DOMAIN export, and domain configuration entry.
  • Tests the ingress IP using a placeholder Host header taken from the Service URL.
  • Adds guidance for configuring a real domain later.
File Description
docs/​cluster-aks.md Simplifies domain-free AKS setup and updates service testing and optional DNS guidance.

Review effort: Balanced

Comment thread docs/cluster-aks.md
Comment on lines +260 to +261
To use a real domain later, set `domain` in `azure.yaml` and create a wildcard
DNS record for `*.default.<domain>` pointing to the ingress address.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Remove the DOMAIN step from the AKS walkthrough

2 participants