Repository navigation
Use sibling TLS identities for direct workspace checks - #65
Open
jsturtevant wants to merge 2 commits into
Open
jsturtevant wants to merge 2 commits into
jsturtevant wants to merge 2 commits into
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the direct workspace hostname changes.
No open issues 🎉
What changed in this PR
Updates direct workspace checks to use each sibling service’s hostname for TLS identity and HTTP routing while preserving the configured TCP destination.
Changes:
- Passes the per-request hostname into connection setup and adds regression tests for HTTPS identities and HTTP destinations.
- Enables trusted HTTPS workspace checks in the selected runtime CI job.
- Documents direct-service ingress setup and hostname/port behavior.
| File | Description |
|---|---|
tests/contracts/test_worker_workspace.py |
Uses the request’s service hostname when opening connections. |
scripts/tests/test_worker_workspace.py |
Tests sibling TLS identities, Host headers, and unchanged connection destinations. |
scripts/test-kind-integration.sh |
Adds optional workspace deployment and trusted HTTPS checks. |
docs/cli/dev.md |
Explains direct-service checks and TLS versus connection addressing. |
.github/workflows/ci.yml |
Enables workspace checks for the selected runtime matrix entry. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the sibling Service hostname for TLS SNI, certificate checks, and the HTTP Host header while keeping the configured TCP destination. This lets direct workspace checks use service-specific HTTPS routing.
Fixes #37.