Skip to content

Use sibling TLS identities for direct workspace checks - #65

Open
jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-37-20261114
Open

jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-37-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Use the sibling Service hostname for TLS SNI, certificate checks, and the HTTP Host header while keeping the configured TCP destination. This lets direct workspace checks use service-specific HTTPS routing.

Fixes #37.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the direct workspace hostname changes.

No open issues 🎉

What changed in this PR

Updates direct workspace checks to use each sibling service’s hostname for TLS identity and HTTP routing while preserving the configured TCP destination.

Changes:

  • Passes the per-request hostname into connection setup and adds regression tests for HTTPS identities and HTTP destinations.
  • Enables trusted HTTPS workspace checks in the selected runtime CI job.
  • Documents direct-service ingress setup and hostname/port behavior.
File Description
tests/​contracts/​test_worker_workspace.py Uses the request’s service hostname when opening connections.
scripts/​tests/​test_worker_workspace.py Tests sibling TLS identities, Host headers, and unchanged connection destinations.
scripts/​test-kind-integration.sh Adds optional workspace deployment and trusted HTTPS checks.
docs/​cli/​dev.md Explains direct-service checks and TLS versus connection addressing.
.github/​workflows/​ci.yml Enables workspace checks for the selected runtime matrix entry.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use sibling service TLS identity in direct workspace checks

2 participants