Repository navigation
Preserve local binding capabilities across relative redirects - #64
Open
jsturtevant wants to merge 2 commits into
Open
jsturtevant wants to merge 2 commits into
jsturtevant wants to merge 2 commits into
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the changes preserving local-binding access across relative redirects.
No open issues 🎉
What changed in this PR
This PR preserves local binding access across relative redirects by resolving them against the application request URL and restoring the capability prefix. External and protocol-relative redirects remain unchanged.
Changes:
- Resolve path-relative redirects without the capability prefix, then restore it.
- Add redirect regression tests and extend stream lifecycle tests to local bindings.
- Document local binding redirect behavior.
| File | Description |
|---|---|
| internal/fiberdintegration/router_lifecycle_test.go | Tests local binding streams through completion and cancellation. |
| internal/fiberdintegration/local.go | Resolves relative redirects and restores the binding capability prefix. |
| internal/fiberdintegration/local_test.go | Tests redirect following, URL components, and unchanged external references. |
| docs/cli/dev.md | Documents capability preservation across relative redirects. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve relative redirects against the application request URL, then restore the local binding capability prefix. Same-Service redirects must retain access without changing external redirects.
Fixes #36.