Skip to content

Preserve local binding capabilities across relative redirects - #64

Open
jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-36-20261114
Open

jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-36-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Resolve relative redirects against the application request URL, then restore the local binding capability prefix. Same-Service redirects must retain access without changing external redirects.

Fixes #36.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the changes preserving local-binding access across relative redirects.

No open issues 🎉

What changed in this PR

This PR preserves local binding access across relative redirects by resolving them against the application request URL and restoring the capability prefix. External and protocol-relative redirects remain unchanged.

Changes:

  • Resolve path-relative redirects without the capability prefix, then restore it.
  • Add redirect regression tests and extend stream lifecycle tests to local bindings.
  • Document local binding redirect behavior.
File Description
internal/​fiberdintegration/​router_lifecycle_test.go Tests local binding streams through completion and cancellation.
internal/​fiberdintegration/​local.go Resolves relative redirects and restores the binding capability prefix.
internal/​fiberdintegration/​local_test.go Tests redirect following, URL components, and unchanged external references.
docs/​cli/​dev.md Documents capability preservation across relative redirects.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve local binding capabilities across relative redirects

2 participants