Repository navigation
Use validated observed Service URLs for deploy and status - #63
Open
jsturtevant wants to merge 2 commits into
Open
jsturtevant wants to merge 2 commits into
jsturtevant wants to merge 2 commits into
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues require further changes.
No open issues 🎉
What changed in this PR
Unifies deploy and status URL reporting around validated, observed Knative Service addresses, addressing issue #32 while preserving custom public hosts and local HTTPS port mappings.
Changes:
- Validates Service identity and requires current-generation observations for status.
- Shares URL handling that preserves public hosts and keeps cluster-local addresses internal.
- Expands regression checks and documents URL reporting and reachability limits.
| File | Description |
|---|---|
scripts/test-existing-kind-integration.sh |
Checks consistent deploy and repeated status URLs across exposure changes. |
docs/cli/status.md |
Documents generation validation and the shared address policy. |
docs/cli/deploy.md |
Clarifies observed URLs, port mappings, and reachability limits. |
cli/tests/kubernetes.rs |
Adds repeated status checks for valid and invalid observations and weighted traffic. |
cli/src/lifecycle.rs |
Validates Service identity and preserves custom public hosts in reported URLs. |
cli/src/kube.rs |
Adds a shared generation-observation check. |
cli/src/event.rs |
Passes expected Service identity to URL validation. |
cli/src/deploy.rs |
Reuses generation validation and checks observed Service and Route identities. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use one observed-address policy for deploy and status, with Service identity and generation checks. Preserve custom public hosts and local HTTPS port mappings while keeping cluster-local addresses internal.
Fixes #32.