Skip to content

Use validated observed Service URLs for deploy and status - #63

Open
jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-32-20261114
Open

jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-32-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Use one observed-address policy for deploy and status, with Service identity and generation checks. Preserve custom public hosts and local HTTPS port mappings while keeping cluster-local addresses internal.

Fixes #32.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require further changes.

No open issues 🎉

What changed in this PR

Unifies deploy and status URL reporting around validated, observed Knative Service addresses, addressing issue #32 while preserving custom public hosts and local HTTPS port mappings.

Changes:

  • Validates Service identity and requires current-generation observations for status.
  • Shares URL handling that preserves public hosts and keeps cluster-local addresses internal.
  • Expands regression checks and documents URL reporting and reachability limits.
File Description
scripts/​test-existing-kind-integration.sh Checks consistent deploy and repeated status URLs across exposure changes.
docs/​cli/​status.md Documents generation validation and the shared address policy.
docs/​cli/​deploy.md Clarifies observed URLs, port mappings, and reachability limits.
cli/​tests/​kubernetes.rs Adds repeated status checks for valid and invalid observations and weighted traffic.
cli/​src/​lifecycle.rs Validates Service identity and preserves custom public hosts in reported URLs.
cli/​src/​kube.rs Adds a shared generation-observation check.
cli/​src/​event.rs Passes expected Service identity to URL validation.
cli/​src/​deploy.rs Reuses generation validation and checks observed Service and Route identities.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report usable public and cluster-local Knative Service URLs consistently

2 participants