Skip to content

Use collision-free Revision pool and route identities - #62

Open
jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-22-20261114
Open

jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-22-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Use distinct namespace and Revision boundaries in pool keys and route file names. Names that contain double hyphens must not cause separate Revisions to share a pool or overwrite a route file.

This overlaps the router changes for #21; the second PR to merge will need a rebase.

Fixes #22.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change to prevent Revision identity collisions in router pools and route metadata.

No open issues 🎉

What changed in this PR

Prevents distinct Knative Revisions from sharing router pools or overwriting route metadata when names contain double hyphens.

Changes:

  • Uses namespace/revision pool keys and underscore-separated route filenames.
  • Removes legacy metadata only when its document matches the Revision being published or finalized.
  • Adds regression coverage for collision isolation, legacy migration, and router readiness, and documents the identity formats.
File Description
internal/​servingrevision/​controller.go Introduces collision-free filenames and ownership-checked legacy cleanup.
internal/​servingrevision/​controller_test.go Tests metadata isolation, migration, finalization, and router readiness.
internal/​fiberdintegration/​router.go Uses consistent slash-separated pool identities during cloning and reload.
internal/​fiberdintegration/​router_test.go Tests independent pools for colliding names and updates pool-key assertions.
internal/​fiberdintegration/​homes_test.go Updates the pooled-connection test to use the new key format.
docs/​designs/​knative-fiber-serving.md Documents route identities and legacy migration behavior.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a collision-free key for Revision pools and route files

2 participants