Repository navigation
Use collision-free Revision pool and route identities - #62
Open
jsturtevant wants to merge 2 commits into
Open
jsturtevant wants to merge 2 commits into
jsturtevant wants to merge 2 commits into
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change to prevent Revision identity collisions in router pools and route metadata.
No open issues 🎉
What changed in this PR
Prevents distinct Knative Revisions from sharing router pools or overwriting route metadata when names contain double hyphens.
Changes:
- Uses
namespace/revisionpool keys and underscore-separated route filenames. - Removes legacy metadata only when its document matches the Revision being published or finalized.
- Adds regression coverage for collision isolation, legacy migration, and router readiness, and documents the identity formats.
| File | Description |
|---|---|
| internal/servingrevision/controller.go | Introduces collision-free filenames and ownership-checked legacy cleanup. |
| internal/servingrevision/controller_test.go | Tests metadata isolation, migration, finalization, and router readiness. |
| internal/fiberdintegration/router.go | Uses consistent slash-separated pool identities during cloning and reload. |
| internal/fiberdintegration/router_test.go | Tests independent pools for colliding names and updates pool-key assertions. |
| internal/fiberdintegration/homes_test.go | Updates the pooled-connection test to use the new key format. |
| docs/designs/knative-fiber-serving.md | Documents route identities and legacy migration behavior. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use distinct namespace and Revision boundaries in pool keys and route file names. Names that contain double hyphens must not cause separate Revisions to share a pool or overwrite a route file.
This overlaps the router changes for #21; the second PR to merge will need a rebase.
Fixes #22.