Repository navigation
Skip invalid route files without blocking route reloads - #61
Open
jsturtevant wants to merge 2 commits into
Open
jsturtevant wants to merge 2 commits into
jsturtevant wants to merge 2 commits into
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the changes isolating route-file failures from unrelated route updates.
No open issues 🎉
What changed in this PR
This PR isolates route-file failures so invalid metadata cannot block unrelated deployments from updating their routes.
Changes:
- Log and skip unreadable, malformed, or invalid route files.
- Exclude Revisions with duplicate valid metadata while continuing to load unrelated routes.
- Add regression tests and document reload, pool cleanup, and readiness behavior.
| File | Description |
|---|---|
| internal/fiberdintegration/router.go | Skip invalid files and exclude duplicate Revision identities before updating route and pool state. |
| internal/fiberdintegration/router_test.go | Test invalid-file handling, route updates and removal, duplicate rejection, recovery, and pool cleanup. |
| docs/designs/knative-fiber-serving.md | Document metadata rejection and its effects on routing, pools, and readiness. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip invalid route files and reject ambiguous Revision entries while loading the remaining routes. One bad file must not prevent unrelated deployments from updating their routes.
This overlaps the router changes for #22; the second PR to merge will need a rebase.
Fixes #21.