Skip to content

Skip invalid route files without blocking route reloads - #61

Open
jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-21-20261114
Open

jsturtevant wants to merge 2 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-21-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Skip invalid route files and reject ambiguous Revision entries while loading the remaining routes. One bad file must not prevent unrelated deployments from updating their routes.

This overlaps the router changes for #22; the second PR to merge will need a rebase.

Fixes #21.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the changes isolating route-file failures from unrelated route updates.

No open issues 🎉

What changed in this PR

This PR isolates route-file failures so invalid metadata cannot block unrelated deployments from updating their routes.

Changes:

  • Log and skip unreadable, malformed, or invalid route files.
  • Exclude Revisions with duplicate valid metadata while continuing to load unrelated routes.
  • Add regression tests and document reload, pool cleanup, and readiness behavior.
File Description
internal/​fiberdintegration/​router.go Skip invalid files and exclude duplicate Revision identities before updating route and pool state.
internal/​fiberdintegration/​router_test.go Test invalid-file handling, route updates and removal, duplicate rejection, recovery, and pool cleanup.
docs/​designs/​knative-fiber-serving.md Document metadata rejection and its effects on routing, pools, and readiness.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip invalid route files instead of blocking every route reload

2 participants